-
Notifications
You must be signed in to change notification settings - Fork 28
fix: add ability to show caption on mobile or desktop only #491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the api change and its implications needs to be discussed!
src/components/table-content-wrapper/table-content-wrapper.styles.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree @JacobBlomgren. if feature landed in the public api surface—it stays until next major release.
you can mark it as deprecated.
you can make it backwards compatible.
you can introduce new ones and overshadow the old one, but in backwards compatible manner.
you should do a console warning if feature is deprecated.
you should make it easy to discover and remove.
you CANNOT remove it without releasing new major version
@iamstarkov @JacobBlomgren please check again |
@JacobBlomgren how do we mark stuff as experimental ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
We discussed it one more round and decided to not mark stuff as experimental for now but rather iron experimental components out internally before adding them to the ui kit. What would be nice though is to put all deprecated components at the bottom of the github.io page eventually, since we have started to deprecate a lot (which is good). |
No description provided.