Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

feat: add new arrow for new menu #527

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Conversation

mjmonline
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 8, 2019

Coverage Status

Coverage increased (+0.04%) to 79.866% when pulling 609d353 on feat/add-medium-arrow-down into 4dc5db7 on master.

Copy link
Contributor

@JacobBlomgren JacobBlomgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that before ThickArrowDown, we had a thinner arrow that wasn't called arrow but Chevron, ChevronDown. We seemed to distinguish between Chevron and Arrow. I would prefer to continue that distinction. In that case, the ThickArrowDown should also be re-exported as ChevronDownThick, for consistency.

Copy link
Contributor

@JacobBlomgren JacobBlomgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@mjmonline mjmonline merged commit 8e168fc into master Feb 8, 2019
@mjmonline mjmonline deleted the feat/add-medium-arrow-down branch February 8, 2019 12:49
@nordnet-release
Copy link
Member

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants