Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: Question about runner names #542

Closed
ogenstad opened this issue May 14, 2020 · 3 comments
Closed

Discussion: Question about runner names #542

ogenstad opened this issue May 14, 2020 · 3 comments
Assignees
@ogenstad
Milestone
3.0.0

Comments

@ogenstad
Copy link
Collaborator

The new runners were called ParallelRunner and SerialRunner, a thought I have was that the ParallelRunner should perhaps be renamed to ThreadedRunner. Both to better indicate how it is working, but also if other typs of parallel runners are introduced in the future.

What are your thoughts?
@dbarrosop dbarrosop added this to the 3.0.0 milestone May 14, 2020
@dbarrosop
Copy link
Contributor

Sounds good to me, do you want to open a PR renaming it?

@ogenstad
Copy link
Collaborator Author

Sure

@ogenstad ogenstad self-assigned this May 14, 2020
@ogenstad ogenstad mentioned this issue May 14, 2020
Merged
@ogenstad
Copy link
Collaborator Author

Closing this was fixed in #544, don't know why it wasn't auto closed..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogenstad ogenstad

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@dbarrosop @ogenstad