Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: Escaped quote in unquoted value must throw. #6

Open
ImrePyhvel opened this issue Dec 12, 2016 · 0 comments
Open

Parser: Escaped quote in unquoted value must throw. #6

ImrePyhvel opened this issue Dec 12, 2016 · 0 comments
Labels

Comments

@ImrePyhvel
Copy link
Collaborator

  1. Each field may or may not be enclosed in double quotes (however
    some programs, such as Microsoft Excel, do not use double quotes
    at all). If fields are not enclosed with double quotes, then
    double quotes may not appear inside the fields.

Repro steps: add 2 consecutive quotes within a value during parsing (Ex: my""value)
Current behavior: current parser (0.9.2) considers it an escaped quoting char (Ex: my"value)
Expected behavior: By RFC it must be invalid input instead. Exceptions should be thrown stating invalid input.

While current implementation can successfully parse wider range of documents, it is in conflict with RFC4180. As compliance is a main goal for the project then it can be considered a bug.

Added test TestUnquotedValueContaining2QuotesThrows to repro the issue.

@ImrePyhvel ImrePyhvel added the bug label Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant