fix: prefs-manager set pref null to remove this

northword · Jan 11, 2025 · b52923d · b52923d
1 parent ea59bc3
commit b52923d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/scaffold/src/utils/prefs-manager.test.ts b/packages/scaffold/src/utils/prefs-manager.test.ts
@@ -72,6 +72,7 @@ pref("test.boolean.true", true);
     it("should correctly set a null value and remove the preference", () => {
       prefsManager.setPref("test.null", "value");
       prefsManager.setPref("test.null", null);
+      expect(prefsManager.getPrefs()).toEqual({});
       expect(prefsManager.getPref("test.null")).toBeUndefined();
     });
   });

diff --git a/packages/scaffold/src/utils/prefs-manager.ts b/packages/scaffold/src/utils/prefs-manager.ts
@@ -62,8 +62,7 @@ export class PrefsManager {
     if (value === null || value === undefined) {
       if (key in this.prefs)
         delete this.prefs[key];
-      else
-        return;
+      return;
     }
 
     this.prefs[key] = value;