You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 13, 2019. It is now read-only.
I should be allowed to choose a dApp name such as my-test-dapp-1 when prompted
Current Behavior
In the prompt, choosing a dApp name with a number in it fails with Please enter a valid project name
Entering the name on the command line with -n or --name does not have the regex check on name characters so it is possible to specify a dApp name with a number in it
Possible Solution
Add 0-9 to the regex for name sanity checks. Also, add sanity checking to the command-line arg parser to make the behavior consistent in both methods.
Steps to Reproduce (for bugs)
Run create-nos-dapp with no arguments
When prompted for the dApp name, enter a name with a number in it
Context
Minor impact, easy workaround, just reporting this for improved consistency/user-experience
Your Environment
Version used: 0.2.3
Environment name and version (e.g. node.js 9.6.1, yarn 1.6.1, npm 5.6.0): node.js 10.4.1, npm 6.4.1
Operating System and version (desktop or mobile): OSX 10.14.3 Mojave
The text was updated successfully, but these errors were encountered:
Expected Behavior
I should be allowed to choose a dApp name such as
my-test-dapp-1
when promptedCurrent Behavior
In the prompt, choosing a dApp name with a number in it fails with
Please enter a valid project name
Entering the name on the command line with
-n
or--name
does not have the regex check on name characters so it is possible to specify a dApp name with a number in itPossible Solution
Add
0-9
to the regex for name sanity checks. Also, add sanity checking to the command-line arg parser to make the behavior consistent in both methods.Steps to Reproduce (for bugs)
create-nos-dapp
with no argumentsContext
Minor impact, easy workaround, just reporting this for improved consistency/user-experience
Your Environment
The text was updated successfully, but these errors were encountered: