-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Want the ability to see all quotes of a post #616
Comments
Are you a nym of @arthurfranca? |
Heheh I've also pointed out in the past that using However, when i brought back to life NIP-18 and also when I tried to change how reply threads should be built, I had to accept the "rule" that whatever main nostr clients were doing would become the NIPs, even if it was a poor implementaion. So if I want a different behavior, I must send a PR before people had already implemented things. So the immutable reality is this: one variant of the reposts is kind 6 (this you can filter) and the other one is kind 1 with mention and e tag (this you can't really filter). For the kind 1 variant, we could add a But good luck convincing Damus, Amethyst, Coracle, Snort, Iris, Gossip etc to add it or waiting for them to read the updated NIP. |
@alexgleason also check this NIP-17 PR which would also help. |
You know Twitter didn't display quote counts at all until last year perhaps? I think they had a data model pretty similar to Nostr. With that said I think if maybe there is a way to move on with these things slowly and without breaking other clients and without bloating the protocol in the end we could maybe try to do it. |
I think it's a feature users expect, but I definitely see it as part of a long-term plan. For now I just want an issue open. I'll probably try a "q" tag in Ditto later and see how that goes. As arthurfranca said, it's possible to do this without breaking backwards-compatibility. |
|
@arthurfranca It would have to be |
Ok, just saw a random thread on nostr saying Damus (Highlighter also) is using Edit: event example. It has no fallback It is interesting that the |
Yes, the 'q' tag is a good way to handle quotes, I like it a lot. I think we should also keep the e tag with mention marker for a while as fallback but at the end we don't need that or i'm wrong (When I first saw Damus q tag i thought we need both, but i don't find reason keeping that mention e tag, root and reply are still needed for sure) |
yeah, I like no |
I like quotes in replies, but I guess it is fine to not have them. |
yeah damus already uses |
if you're replying then it's already quoted above the thing you're replying to in some sense, so not sure when this makes sense. many clients already use an e tag when quoting and it shows up in damus threads, looks a bit weird. |
@jb55 you created kind 6 reposts that have the stringified JSON of the reposted event inside the But for quotes you decided not to add the stringified JSON in some tag. Why is that? |
it was always just an optimization.. I still could? damus got better at fetching notes inline. it's still not as reliable as kind6 reposts but it works well enough. |
now that we have longer notes like longform, the optimization is looking less attractive. |
q makes sense to me |
I was reluctant to bring this up because of all the drama of NIP-10 and NIP-27, but I think the current solution is still wrong. Quotes of a post should be indexable and able to be viewed.
This is related to #523
I would propose using a "q" tag. It's effectively the same as "e" except it's explicitly a quoted event on kind 1 notes, where "e" is just a reply.
The text was updated successfully, but these errors were encountered: