Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a discord bot #6

Open
kennethreitz opened this issue Feb 11, 2019 · 23 comments
Open

create a discord bot #6

kennethreitz opened this issue Feb 11, 2019 · 23 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kennethreitz
Copy link
Contributor

No description provided.

@rHuggler
Copy link

Working on it

@ParthS007
Copy link
Member

Hi @rHuggler, I can also help with it. :)

@rHuggler
Copy link

Hi @ParthS007, help would be appreciated. I've started working on it this evening and didn't get that far.

https://github.com/rHuggler/krorg-bot
(i created it on my personal account because i don't know if i can create it as KR's organization yet)

It works, but it doesn't look very good (to me) and still doesn't have any validation.
The README is also very poor but I plan to update it tomorrow.

@kennethreitz
Copy link
Contributor Author

@rHuggler ping me on discord when it's ready to be moved in to the org!

@rHuggler
Copy link

I'm thinking about changing to Javascript, the existing Discord API wrappers for Python I've found are outdated and/or have vulnerable versions of other packages as sub-dependencies. Any thoughts on that?

@vimrichie
Copy link
Member

Hey,

I feel like that would be okay to do. Do you have any documentation to review?

If anyone else has any ideas on how to create the bot with python, drop a comment and provide some examples on how to implement.

@kennethreitz
Copy link
Contributor Author

JS sounds fine! as long as it works :)

@ParthS007
Copy link
Member

@kenneth-reitz Is the Bot only for adding a user to Org?

@kennethreitz
Copy link
Contributor Author

we can have it do github notifications too

@ParthS007
Copy link
Member

Yes @kenneth-reitz, We can do the notifications part by adding webhook of the bot and selecting the events that are to be shown as notifications on Discord.

@rHuggler
Copy link

rHuggler commented Feb 13, 2019

Wrapping up the day and it's working now 🎉

I've ran some tests on a private server and a test organization I've created and I was able to add an user. There's still a lot of work to do (input validation, Github response handling, etc.) but it works :)

@kennethreitz
Copy link
Contributor Author

yay!!!!

@rHuggler
Copy link

I need some help figuring out these things:

  • Where to deploy the bot to and how to keep it running (Heroku, I guess?)
  • How to authorize the bot to read & write membership in the organization (in my tests I've used my personal access token and an organization I own)

@ParthS007
Copy link
Member

@rHuggler, We can deploy it on Heroku and we have to enable the worker instance which will keep it running.
For bot authorization, we can get it from @kenneth-reitz

@kennethreitz kennethreitz added the enhancement New feature or request label Feb 14, 2019
@kennethreitz
Copy link
Contributor Author

Heroku works, or glitch.
Let's do this!

@kennethreitz
Copy link
Contributor Author

Make a Heroku app and deploy it, and then we'll transfer the app to my org.

Let's do autodeploys from GitHub too.
And tests so we can auto-merge PRs.

@kennethreitz
Copy link
Contributor Author

tests can just be "does this run"

@rHuggler
Copy link

Alright. It would be good if someone could collaborate as well, I won't be available today

@ParthS007
Copy link
Member

@rHuggler I will be happy to help. :)
Add me as a collaborator on the bot repo and ping me on Discord for further discussion. 👍

@Projjol-zz
Copy link
Member

@rHuggler @ParthS007 I'll be happy to collaborate too 😃 , let me know if there's anything I can help with

@rHuggler
Copy link

rHuggler commented Feb 14, 2019

I'll add you as collaborators when I'm back from lunch

EDIT: Done, you're both invited to be Collaborators. To everyone else, feel free to fork and open a Pull Request!

@sadikkuzu sadikkuzu pinned this issue Feb 14, 2019
@sadikkuzu sadikkuzu added this to the 2019Q1 milestone Feb 14, 2019
@Projjol-zz
Copy link
Member

thanks @rHuggler!

@sadikkuzu sadikkuzu modified the milestones: 2019Q1, 2019Q2 Mar 5, 2019
@sadikkuzu
Copy link
Member

Hi there,
What is the current situation?

@sadikkuzu sadikkuzu removed this from the 2019Q2 milestone May 10, 2019
@sadikkuzu sadikkuzu added this to the 2019Q3 milestone May 10, 2019
@sadikkuzu sadikkuzu unpinned this issue Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants