Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit d967d74

Browse files
committedSep 12, 2024·
[ETX-221] Support Rails 7.2
1 parent 62cceaf commit d967d74

File tree

4 files changed

+5
-10
lines changed

4 files changed

+5
-10
lines changed
 

‎lib/rails_data_migrations/log_entry.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
module RailsDataMigrations
44
class LogEntry < ::ActiveRecord::Base
55
def self.table_name
6-
ENV.fetch("DATA_MIGRATIONS_TABLE_NAME", "data_migrations")
6+
ENV.fetch('DATA_MIGRATIONS_TABLE_NAME', 'data_migrations')
77
end
88

99
def self.create_table

‎lib/rails_data_migrations/migrator.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module RailsDataMigrations
44
class Migrator < ::ActiveRecord::Migrator
5-
self.migrations_paths = [ENV.fetch("DATA_MIGRATIONS_PATH", "db/data_migrations")]
5+
self.migrations_paths = [ENV.fetch('DATA_MIGRATIONS_PATH', 'db/data_migrations')]
66

77
MIGRATOR_SALT = 2053462855
88

@@ -17,7 +17,7 @@ def record_version_state_after_migrating(version)
1717
end
1818

1919
class << self
20-
def get_all_versions
20+
def get_all_versions # rubocop:disable Naming/AccessorMethodName
2121
if LogEntry.table_exists?
2222
LogEntry.all.map { |x| x.version.to_i }.sort
2323
else
@@ -42,7 +42,7 @@ def list_pending_migrations
4242
list_migrations.reject { |m| already_migrated.include?(m.version) }
4343
end
4444

45-
def run_migration(direction, migrations_path, version)
45+
def run_migration(direction, version)
4646
schema_migration = ::ActiveRecord::Base.connection_pool.schema_migration
4747
schema_migration.define_singleton_method(:table_name) { ::RailsDataMigrations::LogEntry.table_name }
4848
internal_metadata = ::ActiveRecord::Base.connection_pool.internal_metadata

‎lib/tasks/data_migrations.rake

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@ namespace :data do
66
def apply_single_migration(direction, version)
77
raise 'VERSION is required' unless version
88

9-
RailsDataMigrations::Migrator.run_migration(
10-
direction,
11-
RailsDataMigrations::Migrator.migrations_path,
12-
version.to_i
13-
)
9+
RailsDataMigrations::Migrator.run_migration(direction, version.to_i)
1410
end
1511

1612
task init_migration: :environment do

‎spec/data_migrations_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
describe RailsDataMigrations do
66
it 'checks for migration log table existence' do
7-
expect(RailsDataMigrations::Migrator.migrations_table_exists?(ActiveRecord::Base.connection)).to be_truthy
87
expect(RailsDataMigrations::Migrator.get_all_versions).to be_blank
98
end
109

0 commit comments

Comments
 (0)
Please sign in to comment.