Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all verification into setters on repo #561

Closed
diogomonica opened this issue Feb 10, 2016 · 4 comments · Fixed by #580
Closed

Move all verification into setters on repo #561

diogomonica opened this issue Feb 10, 2016 · 4 comments · Fixed by #580
Milestone

Comments

@diogomonica
Copy link
Contributor

All the verifications should be moved down to the setters on the repository. The only thing we have to do at the store level is the size verification.

@diogomonica diogomonica added this to the notary/0.2 milestone Feb 10, 2016
@diogomonica
Copy link
Contributor Author

Depends on #563

@cyli
Copy link
Contributor

cyli commented Feb 11, 2016

As per #555 (comment), either the setters on the repo or other functions will perform per-metadata specific content verification. After which we probably will no longer need signed.Verify, which verifies both metadata and signatures, and just signed.VerifySignatures.

@cyli
Copy link
Contributor

cyli commented Feb 12, 2016

Note: on further IRL discussion, we are going to do a walk+visitor pattern to load a TUF repo, and verification should happen on a verification visitor.

@riyazdf
Copy link
Contributor

riyazdf commented Feb 20, 2016

this is related to the builder, and we will have verification in the walker. Moving to 0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants