Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure notation-core-go works with go-cose v1.0.0-rc.2 #92

Closed
shizhMSFT opened this issue Nov 4, 2022 · 1 comment
Closed

Ensure notation-core-go works with go-cose v1.0.0-rc.2 #92

shizhMSFT opened this issue Nov 4, 2022 · 1 comment
Assignees
@patrickzheng200
Milestone
RC-1

Comments

@shizhMSFT
Copy link
Contributor

go-cose will cut a v1.0.0-rc.2 release after resolving veraison/go-cose#110.

We need to make sure that the implementation to veraison/go-cose#110 works with notation-core-go before the release cut.
@shizhMSFT shizhMSFT added this to the RC-1 milestone Nov 4, 2022
@patrickzheng200
Copy link

patrickzheng200 commented Nov 7, 2022 •
edited
Loading

Replaced go-cose with github.com/qmuntal/go-cose v0.0.0-20221104155458-b2a1e5fadeef along with other dependencies accordingly in notation-core-go, notation-go, and notation. Tested both sign and verification from Notation CLI. Works as expected. @shizhMSFT

Repository owner moved this from Todo to Done in Notary Project Planning Board Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickzheng200 patrickzheng200

Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
RC-1
Development

No branches or pull requests
2 participants
@shizhMSFT @patrickzheng200