Merge pull request #143 from tecc/widdix-aws-iam-roles

See #95 and #128. Original code is from @andreaswittig.

Author: tecc

Diff for: libs/server/config.ts

@@ -18,8 +18,9 @@ export type BasicAuthConfiguration = { type: 'basic' } & (
 export type AuthConfiguration = { type: 'none' } | BasicAuthConfiguration;
 
 export interface S3StoreConfiguration {
-    accessKey: string;
-    secretKey: string;
+    detectCredentials: boolean;
+    accessKey?: string;
+    secretKey?: string;
     bucket: string;
     endpoint: string;
     region: string;
@@ -96,16 +97,17 @@ export function loadConfig() {
     }
     // for now, this works
     {
+        store.detectCredentials ??= true;
         store.accessKey = getEnv<string>(
             'STORE_ACCESS_KEY',
             store.accessKey,
-            !store.accessKey
-        ).toString();
+            !store.detectCredentials
+        )?.toString();
         store.secretKey = getEnv<string>(
             'STORE_SECRET_KEY',
             store.secretKey,
-            !store.secretKey
-        ).toString();
+            !store.detectCredentials
+        )?.toString();
         store.bucket = getEnv<string>(
             'STORE_BUCKET',
             store.bucket ?? 'notea',

Diff for: libs/server/store/providers/s3.ts

@@ -40,11 +40,14 @@ export class StoreS3 extends StoreProvider {
             forcePathStyle: config.pathStyle,
             region: config.region,
             endpoint: config.endPoint,
-            credentials: {
+            credentials: ((config.accessKey && config.secretKey) ? {
                 accessKeyId: config.accessKey,
                 secretAccessKey: config.secretKey,
-            },
+            } : undefined),
         });
+        if (!config.accessKey || !config.secretKey) {
+            console.log('[Notea] Environment variables STORE_ACCESS_KEY or STORE_SECRET_KEY is missing. Trying to use IAM role credentials instead ...');
+        }
         this.config = config;
     }