forked from google/syzkaller
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathjobs.go
1884 lines (1797 loc) · 55.2 KB
/
jobs.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright 2017 syzkaller project authors. All rights reserved.
// Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.
package main
import (
"context"
"encoding/json"
"fmt"
"math/rand"
"sort"
"strconv"
"strings"
"time"
"github.com/google/syzkaller/dashboard/dashapi"
"github.com/google/syzkaller/pkg/email"
"github.com/google/syzkaller/pkg/vcs"
db "google.golang.org/appengine/v2/datastore"
"google.golang.org/appengine/v2/log"
"google.golang.org/appengine/v2/user"
)
type testReqArgs struct {
bug *Bug
bugKey *db.Key
bugReporting *BugReporting
user string
extID string
link string
patch []byte
repo string
branch string
jobCC []string
mergeBaseRepo string
mergeBaseBranch string
}
// handleTestRequest added new job to db.
// Returns nil if job added successfully.
// If the arguments are invalid, the error is of type *BadTestRequest.
// If the request was denied, the error is of type *TestRequestDenied.
// All other errors correspond to internal processing problems.
func handleTestRequest(c context.Context, args *testReqArgs) error {
log.Infof(c, "test request: bug=%s user=%q extID=%q patch=%v, repo=%q branch=%q",
args.bug.Title, args.user, args.extID, len(args.patch), args.repo, args.branch)
for _, blocked := range getConfig(c).EmailBlocklist {
if args.user == blocked {
return &TestRequestDeniedError{
fmt.Sprintf("test request from blocked user: %v", args.user),
}
}
}
crash, crashKey, err := findCrashForBug(c, args.bug)
if err != nil {
return fmt.Errorf("failed to find a crash: %w", err)
}
_, _, err = addTestJob(c, &testJobArgs{
testReqArgs: *args,
crash: crash, crashKey: crashKey,
})
if err != nil {
return err
}
// Update bug CC and last activity time.
tx := func(c context.Context) error {
bug := new(Bug)
if err := db.Get(c, args.bugKey, bug); err != nil {
return err
}
bug.LastActivity = timeNow(c)
bugReporting := args.bugReporting
bugReporting = bugReportingByName(bug, bugReporting.Name)
bugCC := strings.Split(bugReporting.CC, "|")
merged := email.MergeEmailLists(bugCC, args.jobCC)
bugReporting.CC = strings.Join(merged, "|")
if _, err := db.Put(c, args.bugKey, bug); err != nil {
return fmt.Errorf("failed to put bug: %w", err)
}
return nil
}
if err := runInTransaction(c, tx, nil); err != nil {
// We've already stored the job, so just log the error.
log.Errorf(c, "failed to update bug: %v", err)
}
return nil
}
type testJobArgs struct {
crash *Crash
crashKey *db.Key
configRef int64
configAppend string
treeOrigin bool
inTransaction bool
testReqArgs
}
func addTestJob(c context.Context, args *testJobArgs) (*Job, *db.Key, error) {
now := timeNow(c)
if err := patchTestJobArgs(c, args); err != nil {
return nil, nil, err
}
if reason := checkTestJob(args); reason != "" {
return nil, nil, &BadTestRequestError{reason}
}
manager, mgrConfig := activeManager(c, args.crash.Manager, args.bug.Namespace)
if mgrConfig != nil && mgrConfig.RestrictedTestingRepo != "" &&
args.repo != mgrConfig.RestrictedTestingRepo {
return nil, nil, &BadTestRequestError{mgrConfig.RestrictedTestingReason}
}
patchID, err := putText(c, args.bug.Namespace, textPatch, args.patch)
if err != nil {
return nil, nil, err
}
configRef := args.configRef
if args.configAppend != "" {
kernelConfig, _, err := getText(c, textKernelConfig, configRef)
if err != nil {
return nil, nil, err
}
configRef, err = putText(c, args.bug.Namespace, textKernelConfig,
append(kernelConfig, []byte(args.configAppend)...))
if err != nil {
return nil, nil, err
}
}
reportingName := ""
if args.bugReporting != nil {
reportingName = args.bugReporting.Name
}
job := &Job{
Type: JobTestPatch,
Created: now,
User: args.user,
CC: args.jobCC,
Reporting: reportingName,
ExtID: args.extID,
Link: args.link,
Namespace: args.bug.Namespace,
Manager: manager,
BugTitle: args.bug.displayTitle(),
CrashID: args.crashKey.IntID(),
KernelRepo: args.repo,
KernelBranch: args.branch,
MergeBaseRepo: args.mergeBaseRepo,
MergeBaseBranch: args.mergeBaseBranch,
Patch: patchID,
KernelConfig: configRef,
TreeOrigin: args.treeOrigin,
}
var jobKey *db.Key
deletePatch := false
tx := func(c context.Context) error {
deletePatch = false
// We can get 2 emails for the same request: one direct and one from a mailing list.
// Filter out such duplicates (for dup we only need link update).
var jobs []*Job
var keys []*db.Key
var err error
if args.extID != "" {
keys, err = db.NewQuery("Job").
Ancestor(args.bugKey).
Filter("ExtID=", args.extID).
GetAll(c, &jobs)
if len(jobs) > 1 || err != nil {
return fmt.Errorf("failed to query jobs: jobs=%v err=%w", len(jobs), err)
}
}
if len(jobs) != 0 {
// The job is already present, update link.
deletePatch = true
job, jobKey = jobs[0], keys[0]
if job.Link != "" || args.link == "" {
return nil
}
job.Link = args.link
if jobKey, err = db.Put(c, jobKey, job); err != nil {
return fmt.Errorf("failed to put job: %w", err)
}
return nil
}
jobKey, err = saveJob(c, job, args.bugKey)
return err
}
if args.inTransaction {
err = tx(c)
} else {
err = runInTransaction(c, tx, &db.TransactionOptions{XG: true})
}
if patchID != 0 && (deletePatch || err != nil) {
if err := db.Delete(c, db.NewKey(c, textPatch, "", patchID, nil)); err != nil {
log.Errorf(c, "failed to delete patch for dup job: %v", err)
}
}
if err != nil {
return nil, nil, fmt.Errorf("job tx failed: %w", err)
}
return job, jobKey, nil
}
func saveJob(c context.Context, job *Job, bugKey *db.Key) (*db.Key, error) {
jobKey := db.NewIncompleteKey(c, "Job", bugKey)
var err error
if jobKey, err = db.Put(c, jobKey, job); err != nil {
return nil, fmt.Errorf("failed to put job: %w", err)
}
return jobKey, addCrashReference(c, job.CrashID, bugKey,
CrashReference{CrashReferenceJob, extJobID(jobKey), timeNow(c)})
}
func patchTestJobArgs(c context.Context, args *testJobArgs) error {
if args.branch == "" && args.repo == "" {
// If no arguments were passed, we need to auto-guess them.
build, err := loadBuild(c, args.bug.Namespace, args.crash.BuildID)
if err != nil {
return fmt.Errorf("failed to find the bug reporting object: %w", err)
}
args.branch = build.KernelBranch
args.repo = build.KernelRepo
}
// Let trees be also identified by their alias names.
for _, repo := range getNsConfig(c, args.bug.Namespace).Repos {
if repo.Alias != "" && repo.Alias == args.repo {
args.repo = repo.URL
break
}
}
return nil
}
func crashNeedsRepro(title string) bool {
return !strings.Contains(title, "boot error:") &&
!strings.Contains(title, "test error:") &&
!strings.Contains(title, "build error")
}
func checkTestJob(args *testJobArgs) string {
crash, bug := args.crash, args.bug
needRepro := crashNeedsRepro(crash.Title)
switch {
case needRepro && crash.ReproC == 0 && crash.ReproSyz == 0:
return "This crash does not have a reproducer. I cannot test it."
case !vcs.CheckRepoAddress(args.repo):
return fmt.Sprintf("%q does not look like a valid git repo address.", args.repo)
case !vcs.CheckBranch(args.branch) && !vcs.CheckCommitHash(args.branch):
return fmt.Sprintf("%q does not look like a valid git branch or commit.", args.branch)
case bug.Status == BugStatusFixed:
return "This bug is already marked as fixed. No point in testing."
case bug.Status == BugStatusInvalid:
return "This bug is already marked as invalid. No point in testing."
// TODO(dvyukov): for BugStatusDup check status of the canonical bug.
case args.bugReporting != nil && !args.bugReporting.Closed.IsZero():
return "This bug is already upstreamed. Please test upstream."
}
return ""
}
// Mark bisection job as invalid and, if restart=true, reset bisection state of the related bug.
func invalidateBisection(c context.Context, jobKey *db.Key, restart bool) error {
u := user.Current(c)
tx := func(c context.Context) error {
job := new(Job)
if err := db.Get(c, jobKey, job); err != nil {
return fmt.Errorf("failed to get job: %w", err)
}
if job.Type != JobBisectCause && job.Type != JobBisectFix {
return fmt.Errorf("can only invalidate bisection jobs")
}
// Update the job.
job.InvalidatedBy = u.Email
if _, err := db.Put(c, jobKey, job); err != nil {
return fmt.Errorf("failed to put job: %w", err)
}
if restart {
// Update the bug.
bug := new(Bug)
bugKey := jobKey.Parent()
if err := db.Get(c, bugKey, bug); err != nil {
return fmt.Errorf("failed to get bug: %w", err)
}
if job.Type == JobBisectCause {
bug.BisectCause = BisectNot
} else if job.IsCrossTree() {
bug.FixCandidateJob = ""
} else if job.Type == JobBisectFix {
bug.BisectFix = BisectNot
}
if _, err := db.Put(c, bugKey, bug); err != nil {
return fmt.Errorf("failed to put bug: %w", err)
}
}
return nil
}
if err := runInTransaction(c, tx, &db.TransactionOptions{XG: true}); err != nil {
return fmt.Errorf("update failed: %w", err)
}
return nil
}
type BadTestRequestError struct {
message string
}
func (e *BadTestRequestError) Error() string {
return e.message
}
type TestRequestDeniedError struct {
message string
}
func (e *TestRequestDeniedError) Error() string {
return e.message
}
// pollPendingJobs returns the next job to execute for the provided list of managers.
func pollPendingJobs(c context.Context, managers map[string]dashapi.ManagerJobs) (
*dashapi.JobPollResp, error) {
retry:
job, jobKey, err := getNextJob(c, managers)
if job == nil || err != nil {
return nil, err
}
resp, stale, err := createJobResp(c, job, jobKey)
if err != nil {
return nil, err
}
if stale {
goto retry
}
return resp, nil
}
func getNextJob(c context.Context, managers map[string]dashapi.ManagerJobs) (*Job, *db.Key, error) {
job, jobKey, err := loadPendingJob(c, managers)
if job != nil || err != nil {
return job, jobKey, err
}
// Each syz-ci polls dashboard every 10 seconds. At the times when there are no
// matching jobs, it just doesn't make much sense to execute heavy algorithms that
// try to generate them too often.
// Note that it won't affect user-created jobs as they are not auto-generated.
if err := throttleJobGeneration(c, managers); err != nil {
return nil, nil, err
}
var handlers []func(context.Context, map[string]dashapi.ManagerJobs) (*Job, *db.Key, error)
// Let's alternate handlers, so that neither patch tests nor bisections overrun one another.
if timeNow(c).UnixMilli()%2 == 0 {
handlers = append(handlers, jobFromBugSample, createBisectJob)
} else {
handlers = append(handlers, createBisectJob, jobFromBugSample)
}
for _, f := range handlers {
job, jobKey, err := f(c, managers)
if job != nil || err != nil {
return job, jobKey, err
}
}
return nil, nil, nil
}
const jobGenerationPeriod = time.Minute
func throttleJobGeneration(c context.Context, managers map[string]dashapi.ManagerJobs) error {
drop := map[string]struct{}{}
for name := range managers {
// Technically the key is Namespace+Manager, so it's not guaranteed
// that there'll be only one.
// But for throttling purposes any single entity will do.
// Also note that we do the query outside of the transaction as
// datastore prohibits non-ancestor queries.
keys, err := db.NewQuery("Manager").
Filter("Name=", name).
Limit(1).
KeysOnly().
GetAll(c, nil)
if err != nil {
return err
}
if len(keys) == 0 {
drop[name] = struct{}{}
continue
}
tx := func(c context.Context) error {
manager := new(Manager)
if err := db.Get(c, keys[0], manager); err != nil {
return fmt.Errorf("failed to get %v: %w", keys[0], err)
}
if timeNow(c).Sub(manager.LastGeneratedJob) < jobGenerationPeriod {
drop[name] = struct{}{}
return nil
}
manager.LastGeneratedJob = timeNow(c)
if _, err = db.Put(c, keys[0], manager); err != nil {
return fmt.Errorf("failed to put Manager: %w", err)
}
return nil
}
if err := runInTransaction(c, tx, nil); err != nil {
return fmt.Errorf("failed to throttle: %w", err)
}
}
for name := range drop {
delete(managers, name)
}
return nil
}
// Randomly sample a subset of open bugs with reproducers and try to generate
// a job for them.
// Suitable for cases when we must look deeper than just into Bug fields.
// Sampling allows to evenly spread the load over time.
func jobFromBugSample(c context.Context, managers map[string]dashapi.ManagerJobs) (*Job,
*db.Key, error) {
var managersList []string
for name, jobs := range managers {
if !jobs.Any() {
continue
}
managersList = append(managersList, name)
managersList = append(managersList, decommissionedInto(c, name)...)
}
managersList = unique(managersList)
var allBugs []*Bug
var allBugKeys []*db.Key
for _, mgrName := range managersList {
bugs, bugKeys, err := loadAllBugs(c, func(query *db.Query) *db.Query {
return query.Filter("Status=", BugStatusOpen).
Filter("HappenedOn=", mgrName).
Filter("HeadReproLevel>", 0)
})
if err != nil {
return nil, nil, err
}
bugs, bugKeys = filterBugs(bugs, bugKeys, func(bug *Bug) bool {
if len(bug.Commits) > 0 {
// Let's save resources -- there's no point in doing analysis for bugs
// for which we were already given fixing commits.
return false
}
if getNsConfig(c, bug.Namespace).Decommissioned {
return false
}
return true
})
allBugs = append(allBugs, bugs...)
allBugKeys = append(allBugKeys, bugKeys...)
}
r := rand.New(rand.NewSource(timeNow(c).UnixNano()))
// Bugs often happen on multiple instances, so let's filter out duplicates.
allBugs, allBugKeys = uniqueBugs(c, allBugs, allBugKeys)
r.Shuffle(len(allBugs), func(i, j int) {
allBugs[i], allBugs[j] = allBugs[j], allBugs[i]
allBugKeys[i], allBugKeys[j] = allBugKeys[j], allBugKeys[i]
})
// Also shuffle the creator functions.
funcs := []func(context.Context, []*Bug, []*db.Key,
map[string]dashapi.ManagerJobs) (*Job, *db.Key, error){
createPatchRetestingJobs,
createTreeTestJobs,
createTreeBisectionJobs,
}
r.Shuffle(len(funcs), func(i, j int) { funcs[i], funcs[j] = funcs[j], funcs[i] })
for _, f := range funcs {
job, jobKey, err := f(c, allBugs, allBugKeys, managers)
if job != nil || err != nil {
return job, jobKey, err
}
}
return nil, nil, nil
}
func createTreeBisectionJobs(c context.Context, bugs []*Bug, bugKeys []*db.Key,
managers map[string]dashapi.ManagerJobs) (*Job, *db.Key, error) {
log.Infof(c, "createTreeBisectionJobs is called for %d bugs", len(bugs))
const maxProcess = 5
processed := 0
for _, bug := range bugs {
if bug.FixCandidateJob != "" {
continue
}
if processed >= maxProcess {
break
}
any := false
for _, mgr := range bug.HappenedOn {
newMgr, _ := activeManager(c, mgr, bug.Namespace)
any = any || managers[newMgr].BisectFix
}
if !any {
continue
}
job, key, expensive, err := crossTreeBisection(c, bug, managers)
if job != nil || err != nil {
return job, key, err
}
if expensive {
// Only count expensive lookups.
// If we didn't have to query anything from the DB, it's not a problem to
// examine more bugs.
processed++
}
}
return nil, nil, nil
}
func createTreeTestJobs(c context.Context, bugs []*Bug, bugKeys []*db.Key,
managers map[string]dashapi.ManagerJobs) (*Job, *db.Key, error) {
takeBugs := 5
prio, next := []int{}, []int{}
for i, bug := range bugs {
if !getNsConfig(c, bug.Namespace).FindBugOriginTrees {
continue
}
if timeNow(c).Before(bug.TreeTests.NextPoll) {
continue
}
if bug.TreeTests.NeedPoll {
prio = append(prio, i)
} else {
next = append(next, i)
}
if len(prio) >= takeBugs {
prio = prio[:takeBugs]
break
} else if len(prio)+len(next) > takeBugs {
next = next[:takeBugs-len(prio)]
}
}
for _, i := range append(prio, next...) {
job, jobKey, err := generateTreeOriginJobs(c, bugKeys[i], managers)
if err != nil {
return nil, nil, fmt.Errorf("bug %v job creation failed: %w", bugKeys[i], err)
} else if job != nil {
return job, jobKey, nil
}
}
return nil, nil, nil
}
func createPatchRetestingJobs(c context.Context, bugs []*Bug, bugKeys []*db.Key,
managers map[string]dashapi.ManagerJobs) (*Job, *db.Key, error) {
takeBugs := 5
for i, bug := range bugs {
if !getNsConfig(c, bug.Namespace).RetestRepros {
// Repro retesting is disabled for the namespace.
continue
}
if getConfig(c).Obsoleting.ReproRetestPeriod == 0 ||
timeNow(c).Sub(bug.LastTime) < getConfig(c).Obsoleting.ReproRetestStart {
// Don't retest reproducers if crashes are still happening.
continue
}
takeBugs--
if takeBugs == 0 {
break
}
job, jobKey, err := handleRetestForBug(c, bug, bugKeys[i], managers)
if err != nil {
return nil, nil, fmt.Errorf("bug %v repro retesting failed: %w", bugKeys[i], err)
} else if job != nil {
return job, jobKey, nil
}
}
return nil, nil, nil
}
func decommissionedInto(c context.Context, jobMgr string) []string {
var ret []string
for _, nsConfig := range getConfig(c).Namespaces {
for name, mgr := range nsConfig.Managers {
if mgr.DelegatedTo == jobMgr {
ret = append(ret, name)
}
}
}
return ret
}
// There are bugs with dozens of reproducer.
// Let's spread the load more evenly by limiting the number of jobs created at a time.
const maxRetestJobsAtOnce = 5
func handleRetestForBug(c context.Context, bug *Bug, bugKey *db.Key,
managers map[string]dashapi.ManagerJobs) (*Job, *db.Key, error) {
crashes, crashKeys, err := queryCrashesForBug(c, bugKey, maxCrashes())
if err != nil {
return nil, nil, err
}
var job *Job
var jobKey *db.Key
now := timeNow(c)
jobsLeft := maxRetestJobsAtOnce
for crashID, crash := range crashes {
if crash.ReproSyz == 0 && crash.ReproC == 0 {
continue
}
if now.Sub(crash.LastReproRetest) < getConfig(c).Obsoleting.ReproRetestPeriod {
continue
}
if crash.ReproIsRevoked {
// No sense in retesting the already revoked repro.
continue
}
// We could have decommissioned the original manager since then.
manager, _ := activeManager(c, crash.Manager, bug.Namespace)
if manager == "" || !managers[manager].TestPatches {
continue
}
if jobsLeft == 0 {
break
}
jobsLeft--
// Take the last successful build -- the build on which this crash happened
// might contain already obsolete repro and branch values.
build, err := lastManagerBuild(c, bug.Namespace, manager)
if err != nil {
return nil, nil, err
}
job, jobKey, err = addTestJob(c, &testJobArgs{
crash: crash,
crashKey: crashKeys[crashID],
configRef: build.KernelConfig,
testReqArgs: testReqArgs{
bug: bug,
bugKey: bugKey,
repo: build.KernelRepo,
branch: build.KernelBranch,
},
})
if err != nil {
return nil, nil, fmt.Errorf("failed to add job: %w", err)
}
}
return job, jobKey, nil
}
func createBisectJob(c context.Context, managers map[string]dashapi.ManagerJobs) (*Job, *db.Key, error) {
// We need both C and syz repros, but the crazy datastore query restrictions
// do not allow to use ReproLevel>ReproLevelNone in the query. So we do 2 separate queries.
// C repros tend to be of higher reliability so maybe it's not bad.
job, jobKey, err := createBisectJobRepro(c, managers, ReproLevelC)
if job != nil || err != nil {
return job, jobKey, err
}
return createBisectJobRepro(c, managers, ReproLevelSyz)
}
func createBisectJobRepro(c context.Context, managers map[string]dashapi.ManagerJobs,
reproLevel dashapi.ReproLevel) (*Job, *db.Key, error) {
causeManagers := make(map[string]bool)
fixManagers := make(map[string]bool)
for mgr, jobs := range managers {
if jobs.BisectCause {
causeManagers[mgr] = true
}
if jobs.BisectFix {
fixManagers[mgr] = true
}
}
job, jobKey, err := findBugsForBisection(c, causeManagers, reproLevel, JobBisectCause)
if job != nil || err != nil {
return job, jobKey, err
}
return findBugsForBisection(c, fixManagers, reproLevel, JobBisectFix)
}
func findBugsForBisection(c context.Context, managers map[string]bool,
reproLevel dashapi.ReproLevel, jobType JobType) (*Job, *db.Key, error) {
if len(managers) == 0 {
return nil, nil, nil
}
// Note: we could also include len(Commits)==0 but datastore does not work this way.
// So we would need an additional HasCommits field or something.
// Note: For JobBisectCause, order the bugs from newest to oldest. For JobBisectFix,
// order the bugs from oldest to newest.
// Sort property should be the same as property used in the inequality filter.
// We only need 1 job, but we skip some because the query is not precise.
bugs, keys, err := loadAllBugs(c, func(query *db.Query) *db.Query {
query = query.Filter("Status=", BugStatusOpen)
if jobType == JobBisectCause {
query = query.Filter("FirstTime>", time.Time{}).
Filter("ReproLevel=", reproLevel).
Filter("BisectCause=", BisectNot).
Order("-FirstTime")
} else {
query = query.Filter("LastTime>", time.Time{}).
Filter("ReproLevel=", reproLevel).
Filter("BisectFix=", BisectNot).
Order("LastTime")
}
return query
})
if err != nil {
return nil, nil, fmt.Errorf("failed to query bugs: %w", err)
}
for bi, bug := range bugs {
if !shouldBisectBug(c, bug, managers, jobType) {
continue
}
crash, crashKey, err := bisectCrashForBug(c, bug, keys[bi], managers, jobType)
if err != nil {
return nil, nil, err
}
if crash == nil {
continue
}
return createBisectJobForBug(c, bug, crash, keys[bi], crashKey, jobType)
}
return nil, nil, nil
}
func shouldBisectBug(c context.Context, bug *Bug, managers map[string]bool, jobType JobType) bool {
// We already have a fixing commit, no need to bisect.
if len(bug.Commits) != 0 {
return false
}
if getNsConfig(c, bug.Namespace).Decommissioned {
return false
}
// There likely is no fix yet, as the bug recently reproduced.
const fixJobRepeat = 24 * 30 * time.Hour
if jobType == JobBisectFix && timeSince(c, bug.LastTime) < fixJobRepeat {
return false
}
// Likely to find the same (invalid) result without admin intervention, don't try too often.
const causeJobRepeat = 24 * 7 * time.Hour
if jobType == JobBisectCause && timeSince(c, bug.LastCauseBisect) < causeJobRepeat {
return false
}
// Ensure one of the managers the bug reproduced on is taking bisection jobs.
for _, mgr := range bug.HappenedOn {
if managers[mgr] {
return true
}
}
return false
}
func bisectCrashForBug(c context.Context, bug *Bug, bugKey *db.Key, managers map[string]bool, jobType JobType) (
*Crash, *db.Key, error) {
crashes, crashKeys, err := queryCrashesForBug(c, bugKey, maxCrashes())
if err != nil {
return nil, nil, err
}
for ci, crash := range crashes {
if crash.ReproSyz == 0 || !managers[crash.Manager] {
continue
}
if jobType == JobBisectFix &&
getNsConfig(c, bug.Namespace).Managers[crash.Manager].FixBisectionDisabled {
continue
}
return crash, crashKeys[ci], nil
}
return nil, nil, nil
}
func createBisectJobForBug(c context.Context, bug0 *Bug, crash *Crash, bugKey, crashKey *db.Key, jobType JobType) (
*Job, *db.Key, error) {
build, err := loadBuild(c, bug0.Namespace, crash.BuildID)
if err != nil {
return nil, nil, err
}
now := timeNow(c)
job := &Job{
Type: jobType,
Created: now,
Namespace: bug0.Namespace,
Manager: crash.Manager,
KernelRepo: build.KernelRepo,
KernelBranch: build.KernelBranch,
BugTitle: bug0.displayTitle(),
CrashID: crashKey.IntID(),
}
var jobKey *db.Key
tx := func(c context.Context) error {
jobKey = nil
bug := new(Bug)
if err := db.Get(c, bugKey, bug); err != nil {
return fmt.Errorf("failed to get bug %v: %w", bugKey.StringID(), err)
}
if jobType == JobBisectFix && bug.BisectFix != BisectNot ||
jobType == JobBisectCause && bug.BisectCause != BisectNot {
// Race, we could do a more complex retry, but we just rely on the next poll.
job = nil
return nil
}
if jobType == JobBisectCause {
bug.BisectCause = BisectPending
} else {
bug.BisectFix = BisectPending
}
if _, err := db.Put(c, bugKey, bug); err != nil {
return fmt.Errorf("failed to put bug: %w", err)
}
jobKey, err = saveJob(c, job, bugKey)
return err
}
if err := runInTransaction(c, tx, &db.TransactionOptions{
// We're accessing two different kinds in addCrashReference.
XG: true,
}); err != nil {
return nil, nil, fmt.Errorf("create bisect job tx failed: %w", err)
}
return job, jobKey, nil
}
func createJobResp(c context.Context, job *Job, jobKey *db.Key) (*dashapi.JobPollResp, bool, error) {
jobID := extJobID(jobKey)
patch, _, err := getText(c, textPatch, job.Patch)
if err != nil {
return nil, false, err
}
bugKey := jobKey.Parent()
crashKey := db.NewKey(c, "Crash", "", job.CrashID, bugKey)
crash := new(Crash)
if err := db.Get(c, crashKey, crash); err != nil {
return nil, false, fmt.Errorf("job %v: failed to get crash: %w", jobID, err)
}
build, err := loadBuild(c, job.Namespace, crash.BuildID)
if err != nil {
return nil, false, err
}
configRef := job.KernelConfig
if configRef == 0 {
configRef = build.KernelConfig
}
kernelConfig, _, err := getText(c, textKernelConfig, configRef)
if err != nil {
return nil, false, err
}
reproC, _, err := getText(c, textReproC, crash.ReproC)
if err != nil {
return nil, false, err
}
reproSyz, err := loadReproSyz(c, crash)
if err != nil {
return nil, false, err
}
now := timeNow(c)
stale := false
tx := func(c context.Context) error {
stale = false
job = new(Job)
if err := db.Get(c, jobKey, job); err != nil {
return fmt.Errorf("job %v: failed to get in tx: %w", jobID, err)
}
if !job.Finished.IsZero() {
// This happens sometimes due to inconsistent db.
stale = true
return nil
}
job.Attempts++
job.IsRunning = true
job.LastStarted = now
if _, err := db.Put(c, jobKey, job); err != nil {
return fmt.Errorf("job %v: failed to put: %w", jobID, err)
}
return nil
}
if err := runInTransaction(c, tx, nil); err != nil {
return nil, false, err
}
if stale {
return nil, true, nil
}
resp := &dashapi.JobPollResp{
ID: jobID,
Manager: job.Manager,
KernelRepo: job.KernelRepo,
KernelBranch: job.KernelBranch,
MergeBaseRepo: job.MergeBaseRepo,
MergeBaseBranch: job.MergeBaseBranch,
KernelCommit: job.BisectFrom,
KernelConfig: kernelConfig,
SyzkallerCommit: build.SyzkallerCommit,
Patch: patch,
ReproOpts: crash.ReproOpts,
ReproSyz: reproSyz,
ReproC: reproC,
}
if resp.KernelCommit == "" {
resp.KernelCommit = build.KernelCommit
resp.KernelCommitTitle = build.KernelCommitTitle
}
switch job.Type {
case JobTestPatch:
resp.Type = dashapi.JobTestPatch
case JobBisectCause:
resp.Type = dashapi.JobBisectCause
case JobBisectFix:
resp.Type = dashapi.JobBisectFix
default:
return nil, false, fmt.Errorf("bad job type %v", job.Type)
}
return resp, false, nil
}
// It would be easier to just check if the User field is empty, but let's also not
// miss the situation when some actual user sends a patch testing request without
// patch.
func isRetestReproJob(job *Job, build *Build) bool {
return (job.Type == JobTestPatch || job.Type == JobBisectFix) &&
job.Patch == 0 &&
job.KernelRepo == build.KernelRepo &&
job.KernelBranch == build.KernelBranch
}
func handleRetestedRepro(c context.Context, now time.Time, job *Job, jobKey *db.Key,
bug *Bug, lastBuild *Build, req *dashapi.JobDoneReq) (*Bug, error) {
bugKey := jobKey.Parent()
if bug == nil {
bug = new(Bug)
if err := db.Get(c, bugKey, bug); err != nil {
return nil, fmt.Errorf("failed to get bug: %v", bugKey)
}
}
crashKey := db.NewKey(c, "Crash", "", job.CrashID, bugKey)
crash := new(Crash)
if err := db.Get(c, crashKey, crash); err != nil {
return nil, fmt.Errorf("failed to get crash: %v", crashKey)
}
allTitles := gatherCrashTitles(req)
// Update the crash.
crash.LastReproRetest = now
if req.Error == nil && !crash.ReproIsRevoked {
// If repro testing itself failed, it might be just a temporary issue.
if job.Type == JobTestPatch {
// If there was any crash at all, the repro is still not worth discarding.
crash.ReproIsRevoked = len(allTitles) == 0
} else if job.Type == JobBisectFix {
// More than one commit is suspected => repro stopped working at some point.
crash.ReproIsRevoked = len(req.Commits) > 0
}
}
crash.UpdateReportingPriority(c, lastBuild, bug)
if _, err := db.Put(c, crashKey, crash); err != nil {
return nil, fmt.Errorf("failed to put crash: %w", err)
}
reproCrashes, crashKeys, err := queryCrashesForBug(c, bugKey, 2)
if err != nil {
return nil, fmt.Errorf("failed to fetch crashes with repro: %w", err)
}
// Now we can update the bug.
bug.HeadReproLevel = ReproLevelNone
for id, bestCrash := range reproCrashes {
if crashKeys[id].Equal(crashKey) {
// In Datastore, we don't see previous writes in a transaction...
bestCrash = crash
}
if bestCrash.ReproIsRevoked {
continue
}
if bestCrash.ReproC > 0 {
bug.HeadReproLevel = ReproLevelC
} else if bug.HeadReproLevel != ReproLevelC && bestCrash.ReproSyz > 0 {
bug.HeadReproLevel = ReproLevelSyz
}
}
if stringInList(allTitles, bug.Title) || stringListsIntersect(bug.AltTitles, allTitles) {
// We don't want to confuse users, so only update LastTime if the generated crash
// really relates to the existing bug.
bug.LastTime = now
}
return bug, nil
}
func gatherCrashTitles(req *dashapi.JobDoneReq) []string {
ret := append([]string{}, req.CrashAltTitles...)
if req.CrashTitle != "" {
ret = append(ret, req.CrashTitle)
}
return ret
}
// resetJobs is called to indicate that, for the specified managers, all started jobs are no longer
// in progress.
func resetJobs(c context.Context, req *dashapi.JobResetReq) error {
var jobs []*Job
keys, err := db.NewQuery("Job").
Filter("Finished=", time.Time{}).
Filter("IsRunning=", true).
GetAll(c, &jobs)
if err != nil {
return err