Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide sidebar for vnc.html #1371

Closed
JesterOrNot opened this issue Feb 20, 2020 · 8 comments
Closed

Hide sidebar for vnc.html #1371

JesterOrNot opened this issue Feb 20, 2020 · 8 comments

Comments

@JesterOrNot
Copy link

Is your feature request related to a problem? Please describe.
See gitpod-io/workspace-images#170
We find it distracting
Describe the solution you'd like
A way to remove the sidebar

@samhed samhed added the ui/full label Feb 20, 2020
@samhed
Copy link
Member

samhed commented Feb 20, 2020

When connected it should fold away automatically, in this state it only shows a small handle that shouldn't be obtrusive.

If you want to get rid of it completely you should set display: none on "noVNC_control_bar_anchor" in your CSS. That should do the trick.

@CendioOssman
Copy link
Member

This is a commonly discussed when integrating noVNC in to other systems, so I think this is worth having open and investigating further.

@JesterOrNot, the toolbar is needed for many user interactions (e.g. touch, clipboard). Is this something you've considered? Perhaps there are other ways than just completely removing the toolbar.

@samhed
Copy link
Member

samhed commented Feb 21, 2020

In that case, @JesterOrNot what were you expecting? Documentation in the wiki?

@JesterOrNot
Copy link
Author

The option to completely remove it possibly as something that could be dynamically toggled so that we could create a configuration for it on a per-user basis

@samhed
Copy link
Member

samhed commented Feb 21, 2020

When you say "dynamically toggled", how do you envision doing that? Could you elaborate a bit?

When thinking about integrating and modifying noVNC, changing the html and css seems like the most natural path to me. But that doesn't feel like "dynamically toggling on a per-user basis".

@JesterOrNot
Copy link
Author

You're probably right currently our VNC looks like this
image

and a lot of the time this is just distracting as we currently have very little preview space as is (unless opened in the browser)
image

@CendioOssman
Copy link
Member

How about when it is hidden? Is it still in the way with just the handle?

Have you thought about styling it in a different way? We might be able to make that easier if we know what you need/want.

@samhed
Copy link
Member

samhed commented May 1, 2020

No response.

@samhed samhed closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants