-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash links don't update config #1596
Labels
Comments
This is unfortunately non-trivial as we have to know which parts of the hash that the user actually cares about. We don't want to blindly overwrite settings the user has manually changed in the UI. I'll leave this open though if someone wants to attempt a fix for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Changes in the URL hash don't propagate to the config, instead requiring a page reload to become active.
To Reproduce
Steps to reproduce the behavior:
vnc.html
without get variables or hash#path=/other-websockify
to URL/websockify
despite the changeExpected behavior
The hash change event was hooked and the config updated, so the application connects to
/other-websockify
Client:
Server:
Additional context
In addition to manual updates, this affects updates done by clicking links added to vnc.html, e.g.
<a href="#path=/other-ws">...</a>
I worked around this by adding the following line to
addSettingsHandlers()
inapp/ui.js
:window.addEventListener("hashchange", UI.initSettings, false);
The text was updated successfully, but these errors were encountered: