Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right Click and Double Click on iPad with Trackpad #1722

Open
dead-beef-cafe opened this issue Dec 7, 2022 · 7 comments
Open

Right Click and Double Click on iPad with Trackpad #1722

dead-beef-cafe opened this issue Dec 7, 2022 · 7 comments
Labels

Comments

@dead-beef-cafe
Copy link

Describe the bug:
Right clicks and double clicks on an trackpad connected to an iPad running iOS 16 result in undesirable behavior.
Right clicks (two finger click) will bring up the browser context menu.
Double clicks will select the remote desktop view area as if you are selecting text.

To Reproduce:

  1. Connect to a remote desktop
    2a. Right click anywhere -> the browser context menu will come up in addition to the remote right click menu
    2b. Double click anywhere -> the remote desktop view will be selected, the double click action is also transmitted to the remote desktop

Expected behavior:
Click events on the remote desktop view should be transmitted to the remote desktop only, not processed by the local os/browser.

Screenshots:
C8D24E54-61FD-4DB3-B576-7400C028B3B7
82F6E710-38D4-4D59-AC59-3CBA971B3D2C
Note: The issue with double click is subtle but the entire remote desktop view is slightly blue-er than the other photo.

Client:
OS: iPadOS 16.1.1
Browser: Mobile Safari
Browser version: 16.1.1 (built in to OS)

Server:
OS: Proxmox 7.3
noVNC version: 1.3.0-3
VNC server: QEMU
WebSocket proxy: proxmox-websocket-tunnel

Additional Information:
I think this issue was first introduced in iPadOS 16. The ipad update made trackpads and mice behave a lot more like they do on a traditional desktop. Hopefully there is a way to suppress the local context menu and text selection.

@CendioOssman
Copy link
Member

I can confirm both issues here on both iOS 15 and iOS 16. I used the older trackpad, though, which needs to do Ctrl+click to do a right click.

The selection issue should be mostly resolved by 7e29e02. So if you try a development version it should work better.

The right click issue is not resolved, though.

@dead-beef-cafe
Copy link
Author

Can I just copy the newest base.css into the appropriate folder on my server, or do I need to install the entire git noNVC stack?

@CendioOssman
Copy link
Member

Unknown. We don't test any such combinations. If you want to patch 1.3.0 then I would suggest manually adding those lines in the referenced commit.

@dead-beef-cafe
Copy link
Author

Ok, I’m not too thrilled about installing the dev branch on my server but I guess my workaround is probably just as dangerous. It’s just a homelab so let’s go for it.

@dead-beef-cafe
Copy link
Author

I tried copying the two lines from 7e29e02 into the appropriate spot in /usr/share/novnc-pve/app/styles/base.css and it did prevent the selection bug, but it also introduced a new bug where sometimes left clicks were not sent to the remote system. The position of the cursor would update but the click would not register.

I think I will just have to wait for Proxmox to update their stable package.

@jpnaidu07
Copy link

@CendioOssman Thanks to the team for this bug fixed.

But this issue still exists in Local Scaling mode though working fine in Remote resizing.

Please let us know if there is any option to enable this in Local Scaling mode as well.

Setup
NoVNC -> 1.4.0
Server -> TightVNC -> 2.8.63

@CendioOssman
Copy link
Member

The scaling mode should not be relevant here, so that is unexpected.

There are two issues described here, and only one has been resolved. Exactly what problem are you still seeing with 1.4.0, and exactly what are you doing to reproduce it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants