-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing methods #72
Comments
@sumitsaurabh927 really glad that you are interested in the library and wondering if you would like to help out. You are right that not all endpoints are implemented but that that there are already issues logged #66 #67 #68 #70 and some in your list are already implemented which makes your report a bit misleading (particularly if you scanning the issues as a newbie). IT would be really helpful if you could do a full reconciliation against the API including the version the API was introduced and last changed. For example, I think you have missed tenants. I'd be really keen to accept this as documentation in a pull request. Are you interested? |
Hey @toddb I along with my colleagues from the devX team had been working to port documentation. Having been working on api reference documentation, it came to my attention that not all the endpoints were listed in the readme and you're right, I should have made a detailed issue listing actual missing endpoints. I'll be updating the issue now. Unfortunately, my plate is a little full right now, can you update it once I've updated the issue? |
@sumitsaurabh927 Could you tell me a little more about what you are doing around porting api documentation? I can't tell if you are working on the Novu documentation itself or a more general tool. Could it be of help to use here? or for Novu themselves? SDK libraries really struggle to know when to make changes (as well as the back-filling problem we currently have). |
Hey @toddb sorry if my language created confusion for you. What I meant was I was working on the documentation. One of the tasks assigned to me was adding all the SDK methods for all our SDKs. This is why I created this issue so that someone looking to contribute can compare all the available endpoints and all the implemented ones and add the missing ones. I've identified the following ones that aren't present in the .Net SDK:
I was just wondering if you'd maybe implement all these methods so that we can update our docs. 🙂 |
The SDK isn't up to date with the API specification. |
Compatability: Full, Incomplete, None, Upgrade
Events
Subscribers
Topics
Notification
Integrations
Layouts
Workflows
Workflow Groups
Notes
Environments
Inbound Parse
Feeds
Tenants
Messages
Organizations
Execution Details
Default
|
Some endpoints of the following section can't be hit from this SDK. Please ensure that all the SDK methods are up to date. I'm adding here a list of sections to check/update:
Some of these methods already exist. No need to change/update them. This is just to bring every SDK we have on par with all the methods available.
Check all the endpoints here and add the missing ones.
The text was updated successfully, but these errors were encountered: