Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: @novu/framework Integration with class-validator #6682

Open
2 tasks done
paulwer opened this issue Oct 11, 2024 · 2 comments · May be fixed by #6840
Open
2 tasks done

🚀 Feature: @novu/framework Integration with class-validator #6682

paulwer opened this issue Oct 11, 2024 · 2 comments · May be fixed by #6840
Labels

Comments

@paulwer
Copy link
Contributor

paulwer commented Oct 11, 2024

🔖 Feature description

Hi there,
we are using novu with a nestjs service, and have multiple classes already defined with class-validator for validation and dont use zod right now. Would it be possible to add support for class-validator for schema definition instead of zod?

🎤 Why is this feature needed ?

NestJs and multiple other services are using this lib already for validation and it would help quite alot to just reuse existing classes within the workflow definitions.

✌️ How do you aim to achieve this?

We dont know for certain if there are any technical limitations, but if not it would be great if both libraries could be used as input.

🔄️ Additional Information

class-validator to json schema: https://www.npmjs.com/package/class-validator-jsonschema

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

Copy link

linear bot commented Oct 11, 2024

@paulwer paulwer changed the title 🚀 Feature: NestJs Integration with class-validator 🚀 Feature: @novu/framework Integration with class-validator Nov 1, 2024
@paulwer
Copy link
Contributor Author

paulwer commented Nov 4, 2024

I am currently in the work to provide a PR for this.

@paulwer paulwer linked a pull request Nov 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant