fix(framework): Stop validating controls for non previewed step #6876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Nov 6, 2024
| status: 'success', | ||
| }, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
An empty outputs should have been supplied for this test, ensuring that a hydration can still occur for skipped steps. This fixes the assertion.
rifont
commented
Nov 6, 2024
❌ Deploy Preview for novu-stg-vite-dashboard-poc failed. Why did it fail? →
|
rifont
commented
Nov 6, 2024
| // Only set the result when the step is the current step. | ||
| // Only evaluate a skip condition when the step is the current step and not in preview mode. | ||
| if (!isPreview && stepId === event.stepId) { | ||
| const controls = await this.createStepControls(step, event); |
There was a problem hiding this comment.
With this change, we ensure step controls are only validated during execution where the controls are guaranteed to be available for the current step being executed.
commit: |
❌ Deploy Preview for novu-stg-vite-dashboard-poc failed. Why did it fail? →
|
tatarco
reviewed
Nov 7, 2024
| return {} as any; | ||
| /* | ||
| * Return an empty object for results when a step is skipped. | ||
| * TODO: fix typings when `skip` is specified to return `Partial<T_Result>` |
There was a problem hiding this comment.
just to make sure it doesn't bypass the second PR and results will be supplied if i provide them
There was a problem hiding this comment.
Yes, this code branch is only for the non-preview case.
tatarco
approved these changes
Nov 7, 2024
SokratisVidros
approved these changes
Nov 7, 2024
rifont
deleted the
nv-4602-stop-validating-controls-for-non-previewed-step-in-framework
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
skipstep logical execution, non-previewed steps were having controls validated. This was a bug as no controls are ever supplied to the non-executed step. This change removes controls validation for non-previewed stepsScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer