Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): Prevent adding duplicate workflows #6913

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

rifont
Copy link
Contributor

@rifont rifont commented Nov 11, 2024

What changed? Why was the change needed?

  • Add locking mechanism to prevent adding duplicate workflows in Client.addWorkflows
  • Convert discoveredWorkflows internal Client attribute to a Map for more performant lookups of existing workflows

Screenshots

Before - duplicate workflows could be added if more than 1 Local Studio tab is open in Browser during hot reload
image

After - duplicate workflows are not added
image

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit e6282cd
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6731c9a9c7c2c800085e0cfe
😎 Deploy Preview https://deploy-preview-6913--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/framework/src/client.ts Outdated Show resolved Hide resolved
packages/framework/src/client.ts Show resolved Hide resolved
packages/framework/src/client.ts Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Nov 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6913

commit: e6282cd

@rifont rifont merged commit 3ec534e into next Nov 11, 2024
42 checks passed
@rifont rifont deleted the prevent-duplicate-workflow-discovery branch November 11, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants