Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringReceiversOverlap: Support assignments in dataflow #173

Open
jubnzv opened this issue Oct 12, 2024 · 0 comments
Open

StringReceiversOverlap: Support assignments in dataflow #173

jubnzv opened this issue Oct 12, 2024 · 0 comments
Labels
area:detectors Related to existing detectors false negative

Comments

@jubnzv
Copy link
Member

jubnzv commented Oct 12, 2024

We could add support for the cases like this:

contract C {
    receive("test") {}
    receive(msg: String) {
        let test1: String = "";
        test1 = "abc";
        test1 = "test";
        if (test1 == msg) {} // Bad
    }
}

It would be simpler to implement if we have an SSA IR (or any other IR that makes these assignments more explicit): #74

@jubnzv jubnzv added false negative area:detectors Related to existing detectors labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:detectors Related to existing detectors false negative
Projects
None yet
Development

No branches or pull requests

1 participant