Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can filter years in reference table view with minimum and maximum year range #145

Closed
iritmaximus opened this issue Sep 5, 2024 · 9 comments · Fixed by #474
Closed

Comments

@iritmaximus
Copy link
Collaborator

No description provided.

@EeroAnt
Copy link
Collaborator

EeroAnt commented Oct 4, 2024

#312

@karilint
Copy link
Contributor

If you set the minimum to 2003 and the maximum to 2005, only the results for 2004 are displayed. Those should be from 2003 to 2005.

@iritmaximus
Copy link
Collaborator Author

This is "intended" behaviour by Material. Here is a demo that has the same behaviour.

@iritmaximus
Copy link
Collaborator Author

Fixed in #474.

@iritmaximus iritmaximus linked a pull request Nov 4, 2024 that will close this issue
@karilint
Copy link
Contributor

karilint commented Nov 7, 2024

Test results:

Currently, it seems that nothing works with the year filtering

@juhanikat juhanikat reopened this Nov 8, 2024
@juhanikat
Copy link
Collaborator

This is now tracked in #527

@karilint
Copy link
Contributor

karilint commented Nov 15, 2024

Tested - OK.

Before moving to "Approved" check if some of the items below make sense

Other comments:
Enter search term: valid entries: (in PHP version)
2004, <2004, >2004,
2004. .2005 (min: 1700,
max: 2024, missing year: O)

@juhanikat
Copy link
Collaborator

Are you referring to the features that are talked about in #132 ?
If so, the fuzzy/exact search feature is tracked in #377
And because we have a different input field for the minimum and maximum year in the table, these search terms are already implemented in a different way: 2004, <2004, >2004, 2004...2005
I am not sure what (min: 1700, max: 2024, missing year: O) means, could you clarify?

@karilint
Copy link
Contributor

Test results: Approved

You are right. Those PHP search terms are now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants