Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item entry discarded without confirmation #114

Open
dnnr opened this issue Feb 20, 2022 · 1 comment
Open

Item entry discarded without confirmation #114

dnnr opened this issue Feb 20, 2022 · 1 comment
Labels

Comments

@dnnr
Copy link
Contributor

dnnr commented Feb 20, 2022

Observation: When adding a new item, after having typed some content into the form, pressing the escape key does not prompt for any confirmation. Instead, everything entered is lost.

Expected behavior: Do not loose entered data without a confirmation prompt. Alternatively, keep the contents and show them when opening the new item form again. Or just don't react on escape key presses.

@noyainrain noyainrain added the bug label Mar 1, 2022
@noyainrain noyainrain changed the title Don't abort item entry without confirmation Item entry discarded without confirmation Mar 1, 2022
@noyainrain
Copy link
Owner

Thanks for the bug report! 🙂 Indeed, simply closing a form should not lead to data loss. I agree with the two possible solutions you point out (either restore the data later or ask for user confirmation).

When reproducing the issue, I noticed two things: Data is currently restored when editing the list itself (but maybe consistently using a prompt is the better solution). The described problem also occurs when navigating away from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants