Partial Product Update Broken

[lantram]

Using a sample store with a product catalog from here ("jewelry.csv"):

https://github.com/shopifypartners/product-csvs

If I do this:

await productService.UpdateAsync(product.Id.Value,
    new Product()
    {
        Title = "New product title"
    });

It messes up the store. In particular, it makes the product unavailable (removes the online store sales channel). I don't know if anything else is affected.

Instead I have to do this:

var product = await productService.GetAsync(productId);
product.Title = "New product title";
await productService.UpdateAsync(product.Id.Value,product);

The documentation on Updating a product at https://github.com/nozzlegear/ShopifySharp#products says we can do this:

var service = new ProductService(myShopifyUrl, shopAccessToken);
var product = await service.UpdateAsync(productId, new Product()
{
    Title = "New product title"
});

However, that is not currently correct since it appears to be broken.

[nozzlegear]

I'm currently working on a ShopifySharp.Experimental package, with the main goal of introducing a new way to create/update objects without accidentally sending values you didn't intend to send (including null). I'll update here when it's published.

#388

[shafaqat-ali-cms365]

I am having the same issue, I had 5000 products and I updated all of them and now all products have been removed form the the Online Store channel. Please help, all products have been unlinked from the online store channel.

Any temporary fix or anything, please help.

[nozzlegear]

Hey @shafaqat-ali-cms365, this issue is partially out of date as it doesn't contain the fix for the problem. I'm keeping it open because I'm still planning a better, more encompassing fix in 6.0.

The problem is, because of the nature of C# and Json.Net, fields that you don't explicitly set on an object will get serialized to their default C# value. For a nullable date field, that value is null which unpublishes your products. When updating the product, you need to explicitly set the PublishedAt value so it doesn't get serialized to null:

var product = await service.UpdateAsync(new Product
{
    PublishedAt = someDateTimeValue,
    // And other updated values here 
});