Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Admin API rate limits #403

Closed
andre719mv opened this issue Oct 10, 2019 · 7 comments
Closed

GraphQL Admin API rate limits #403

andre719mv opened this issue Oct 10, 2019 · 7 comments
Labels

Comments

@andre719mv
Copy link

Hi!
I am successfully use SmartExecutionPolicy to handle call limits in the REST admin API. But it seems that GraphQL return API limit usage in different format and their docs does not say anything about 429 response for GraphQL https://help.shopify.com/en/api/graphql-admin-api/graphql-admin-api-rate-limits. Is it possible to implement proper limit handling for GraphQL?

@clement911
Copy link
Collaborator

No unfortunately this has not been implemented yet in ShopifySharp.

@andre719mv
Copy link
Author

It will be very useful. The reason I want to use GraphQL is to make less of API calls and to not reach limits. But without limit handling I can not use it. Thanks for response.

@clement911
Copy link
Collaborator

I agree totally.
I wanted to start on this but got side tracked.
ShopifySharp has very limited support for GraphQL.

@andre719mv
Copy link
Author

I implemented leaky bucket for Graph API in my project. Will try to share some code later.

@andre719mv
Copy link
Author

Hi!
I created some PR so you can see my idea #486
I already use it well in my project.

@clement911
Copy link
Collaborator

I submitted a PR with a new policy to handle GraphQL rate limits.
#667

@clement911
Copy link
Collaborator

This is now released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants