Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Note about unsupported Regex options #329

Open
WhatzGames opened this issue Jan 16, 2024 · 2 comments
Open

Add Note about unsupported Regex options #329

WhatzGames opened this issue Jan 16, 2024 · 2 comments

Comments

@WhatzGames
Copy link

As npgsql/efcore.pg#2818 showed, it is not clear on what RegexOptions are actually supported.
I suggest adding a note to the tranlation docs to make it clearer for everyone.

@roji
Copy link
Member

roji commented Jan 16, 2024

Do you think it's really necessary, given that users get a "cannot translate" exception if they try an unsupported version?

In any case, if you think it's important, feel free to submit a PR updating the translations doc page.

@WhatzGames
Copy link
Author

I don't think it's an absolute necessity, but the exception is not too clear about why it would fail.
Providing the information about what option is supported or not would at least clarify it.

As soon as I got the time I'll see to add a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants