Annotate functional tests for nullability

Where the base classes are annotated

Author: roji

Directory.Build.props

@@ -3,6 +3,7 @@
     <VersionPrefix>10.0.0</VersionPrefix>
     <TargetFramework>net10.0</TargetFramework>
     <LangVersion>latest</LangVersion>
+    <Nullable>enable</Nullable>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <AnalysisLevel>latest</AnalysisLevel>
     <NoWarn>NU5105</NoWarn>

src/Directory.Build.props

@@ -5,7 +5,6 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
-    <Nullable>enable</Nullable>
     <Feature>nullablePublicOnly</Feature>
   </PropertyGroup>
 

test/EFCore.PG.FunctionalTests/BadDataJsonDeserializationNpgsqlTest.cs

@@ -1,5 +1,3 @@
-#nullable enable
-
 namespace Npgsql.EntityFrameworkCore.PostgreSQL;
 
 public class BadDataJsonDeserializationSqlServerTest : BadDataJsonDeserializationTestBase

test/EFCore.PG.FunctionalTests/BatchingTest.cs

@@ -7,6 +7,8 @@
 // ReSharper disable InconsistentNaming
 namespace Npgsql.EntityFrameworkCore.PostgreSQL;
 
+#nullable disable
+
 public class BatchingTest(BatchingTest.BatchingTestFixture fixture) : IClassFixture<BatchingTest.BatchingTestFixture>
 {
     protected BatchingTestFixture Fixture { get; } = fixture;

test/EFCore.PG.FunctionalTests/BuiltInDataTypesNpgsqlTest.cs

@@ -5,6 +5,8 @@
 
 namespace Npgsql.EntityFrameworkCore.PostgreSQL;
 
+#nullable disable
+
 public class BuiltInDataTypesNpgsqlTest : BuiltInDataTypesTestBase<BuiltInDataTypesNpgsqlTest.BuiltInDataTypesNpgsqlFixture>
 {
     // ReSharper disable once UnusedParameter.Local

test/EFCore.PG.FunctionalTests/BulkUpdates/NonSharedModelBulkUpdatesNpgsqlTest.cs

@@ -236,7 +236,7 @@ protected class Context3001(DbContextOptions options) : DbContext(options)
     protected class EntityWithPrimitiveCollection
     {
         public int Id { get; set; }
-        public List<string> Tags { get; set; }
+        public List<string> Tags { get; set; } = null!;
     }
 
     public override async Task Delete_with_view_mapping(bool async)

test/EFCore.PG.FunctionalTests/ComputedColumnTest.cs

@@ -134,7 +134,7 @@ public void Can_use_computed_columns_with_nullable_enum()
         Assert.Equal(FlagEnum.AValue | FlagEnum.BValue, entity.CalculatedFlagEnum);
     }
 
-    protected NpgsqlTestStore TestStore { get; private set; }
+    protected NpgsqlTestStore TestStore { get; private set; } = null!;
 
     public async Task InitializeAsync()
         => TestStore = await NpgsqlTestStore.CreateInitializedAsync("ComputedColumnTest");

test/EFCore.PG.FunctionalTests/ConferencePlannerNpgsqlTest.cs

@@ -4,6 +4,8 @@
 
 namespace Npgsql.EntityFrameworkCore.PostgreSQL;
 
+#nullable disable
+
 public class ConferencePlannerNpgsqlTest(ConferencePlannerNpgsqlTest.ConferencePlannerNpgsqlFixture fixture)
     : ConferencePlannerTestBase<ConferencePlannerNpgsqlTest.ConferencePlannerNpgsqlFixture>(fixture)
 {

test/EFCore.PG.FunctionalTests/ConnectionInterceptionNpgsqlTest.cs

@@ -1,5 +1,6 @@
 using System.Data;
 using System.Data.Common;
+using System.Diagnostics.CodeAnalysis;
 using Npgsql.EntityFrameworkCore.PostgreSQL.TestUtilities;
 
 namespace Npgsql.EntityFrameworkCore.PostgreSQL;
@@ -45,6 +46,7 @@ protected override BadUniverseContext CreateBadUniverse(DbContextOptionsBuilder
 
     public class FakeDbConnection : DbConnection
     {
+        [AllowNull]
         public override string ConnectionString { get; set; }
 
         public override string Database

test/EFCore.PG.FunctionalTests/ConnectionSpecificationTest.cs

@@ -4,6 +4,8 @@
 // ReSharper disable StringLiteralTypo
 namespace Npgsql.EntityFrameworkCore.PostgreSQL;
 
+#nullable disable
+
 public class ConnectionSpecificationTest
 {
     [Fact]