Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map range operations #311

Closed
roji opened this issue Feb 22, 2018 · 3 comments
Closed

Map range operations #311

roji opened this issue Feb 22, 2018 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@roji
Copy link
Member

roji commented Feb 22, 2018

With #63 mapping the built-in range types, we should also map range operations so that it's possible to invoke them from C# without dropping down to raw SQL. The list of operators can be found here, and would include stuff like containment. These would be implemented as EF Core extension methods over NpgsqlRange.

If you're interested in this, please upvote and post which operations interest you most.

@roji roji added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2018
@roji roji added this to the 2.1.0 milestone Feb 22, 2018
@austindrenski
Copy link
Contributor

austindrenski commented Mar 4, 2018

I'm new to query operator translation, but if no one else has started in on this, I can take a first pass at it. I've forked the dev branch and have gotten most of the test suite building locally.

So far I've started on the containment operators:

  • NpgsqlRange<T>.Contains(T item)
  • item.ContainedBy(NpgsqlRange<T> range)

Questions:

  • Does the Npgsql team have a contributors guide that I should review?
  • Should I open a pull request while working on this feature, or wait until all of the operators are passing?

@roji
Copy link
Member Author

roji commented Mar 4, 2018

Hi @austindrenski, it's great to have you as a contributor!

There's no style guide really, I suggest you try to follow the conventions you see in the codebase. You're also welcome to send a PR before you're done and I'll review to make sure you're on the right path.

Looking forward to seeing your work!

@roji roji modified the milestones: 2.1.0, Backlog May 12, 2018
@roji roji removed the good first issue Good for newcomers label May 15, 2018
@roji roji modified the milestones: Backlog, 2.1.0 May 15, 2018
@roji
Copy link
Member Author

roji commented May 15, 2018

Thanks for your contribution @austindrenski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants