Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change url #2417

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Change url #2417

merged 1 commit into from
Jan 7, 2021

Conversation

AkiaCode
Copy link
Contributor

References

@AkiaCode AkiaCode requested a review from a team as a code owner December 27, 2020 00:19
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Dec 30, 2020
@ljharb
Copy link
Contributor

ljharb commented Jan 6, 2021

isn't the (1) like unix's man(1) conventions?

@darcyclarke
Copy link
Contributor

darcyclarke commented Jan 6, 2021 •
edited
Loading

@ljharb Correct. The README.md file was removed from our Makefile's man doc generation script in a previous commit though (ie. we can consider README.md to be just like any other generic markdown file again, without the need for that extra syntax/formatting). That said, this file/doc still needs a lot more love/attention & I've got a WIP branch w/ some other changes coming. If you're looking for what is still included in our man docs/help search you can look in /docs/content

@AkiaCode AkiaCode changed the title Change url & Remove (1) Change url Jan 6, 2021
@AkiaCode @isaacs
Fix npm bug reporting url
0fed44d 
PR-URL: #2417
Credit: @AkiaCode
Close: #2417
Reviewed-by: @isaacs
@isaacs isaacs changed the base branch from latest to release/v7.4.0 January 7, 2021 20:36
@isaacs isaacs merged commit 0fed44d into npm:release/v7.4.0 Jan 7, 2021
@ruyadorno ruyadorno mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcyclarke darcyclarke darcyclarke approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkiaCode @ljharb @darcyclarke @isaacs