Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: npm publish --dry-run should not check login status #2422

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix: npm publish --dry-run should not check login status #2422

merged 1 commit into from
Jan 7, 2021

Conversation

buyan302
Copy link

npm7 should not check login status when executing npm publish --dry-run.

See --dry-run. Just keep the same behavior with npm6.

References

Fixes #2411

Test result

image

@buyan302 buyan302 requested a review from a team as a code owner December 29, 2020 11:09
@buyan302
Copy link
Author

test this please ✅

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Dec 30, 2020
@dr-js dr-js mentioned this pull request Jan 6, 2021
Merged
@isaacs isaacs changed the base branch from latest to release/v7.4.0 January 7, 2021 20:37
@isaacs isaacs merged commit b2e2edf into npm:release/v7.4.0 Jan 7, 2021
@ruyadorno ruyadorno mentioned this pull request Jan 7, 2021
Closed
@wraithgar wraithgar mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcyclarke darcyclarke darcyclarke approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
3 participants
@buyan302 @darcyclarke @isaacs