Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the url for RFC 19 so that it isn't a 404. #2440

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Updated the url for RFC 19 so that it isn't a 404. #2440

merged 1 commit into from
Jan 7, 2021

Conversation

jeffgca
Copy link
Contributor

@jeffgca jeffgca commented Jan 4, 2021

When I tried to use npm --depth 9999 update based on some old documentation, I got an error message:

npm WARN update The --depth option no longer has any effect. See RFC0019. npm WARN update https://github.com/npm/rfcs/blob/latest/accepted/0019-remove-update-depth-option.md

I noticed that the url mentioned is a 404, so this change updates the url from

https://github.com/npm/rfcs/blob/latest/accepted/0019-remove-update-depth-option.md

to

https://github.com/npm/rfcs/blob/latest/implemented/0019-remove-update-depth-option.md

Aside: these docs on npm-update still seem to recommend --depth tricks:

https://docs.npmjs.com/cli/v7/commands/npm-update

@jeffgca jeffgca requested a review from a team as a code owner January 4, 2021 20:16
@ruyadorno ruyadorno mentioned this pull request Jan 4, 2021
5 tasks
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Jan 5, 2021
PR-URL: #2440
Credit: @therealjeffg
Close: #2440
Reviewed-by: @isaacs
@isaacs isaacs changed the base branch from latest to release/v7.4.0 January 7, 2021 20:39
@isaacs isaacs merged commit a390d74 into npm:release/v7.4.0 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants