Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues when using workspaces #2600

Closed
lee5i3 opened this issue Feb 2, 2021 · 3 comments
Closed

[BUG] Issues when using workspaces #2600

lee5i3 opened this issue Feb 2, 2021 · 3 comments
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release

Comments

@lee5i3
Copy link

lee5i3 commented Feb 2, 2021

We are having issues with our monorepo project, our package.json has

{
  "private": true,
  "workspaces": [
    "common",
    "base-tests",
    "ttic-fl-ho3",
    "ttic-fl-af3",
    "hcpc-sc-af3",
    "hcpc-nj-af3",
    "ttic-ga-ho3"
  ]
}

When we ran npm install, it use to run fine.. now says

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: common@1.1.1
npm ERR! Found: sinon@9.0.1
npm ERR! node_modules/sinon
npm ERR!   dev sinon@"^9.0.1" from common@1.1.1
npm ERR!   common
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer sinon@"5 - 7" from sinon-mongoose@2.3.0
npm ERR! node_modules/sinon-mongoose
npm ERR!   dev sinon-mongoose@"^2.3.0" from common@1.1.1
npm ERR!   common
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/lhull/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/lhull/.npm/_logs/2021-02-02T22_00_46_902Z-debug.log

This worked on v7.5.0 but now errors on 7.5.1+

2021-02-02T22_00_46_902Z-debug.log

@lee5i3 lee5i3 added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Feb 2, 2021
@plotka
Copy link

plotka commented Feb 10, 2021

I had a similar issue, I solved it by deleting the node-modules folder in the root and by running npm install --legacy-peer-deps

@darcyclarke
Copy link
Contributor

@lee5i3 can you try installing the latest v7 & see if you can reproduce it? (ie. npm install -g npm - 7.6.0)

@darcyclarke darcyclarke removed the Needs Triage needs review for next steps label Feb 26, 2021
@ruyadorno
Copy link
Contributor

I'm going to go ahead and close this one due to inactivity, for more context we have been fixing a lot of these ERESOLVE edge case problems during npm install in the last few months and it's very likely that this one might already have been fixed.

In case anyone arrives here with the same problem, feel free to create a new issue and reference/link to this one.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

4 participants