Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in shrinkwrap.js #2729

Merged
merged 1 commit into from
Feb 22, 2021
Merged

test: fix typo in shrinkwrap.js #2729

merged 1 commit into from
Feb 22, 2021

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Feb 19, 2021 •
edited
Loading

fixed minor typo.
contructor -> constructor

@eltociear eltociear requested a review from a team as a code owner February 19, 2021 07:36
@wraithgar
Copy link
Member

I believe this was meant to be constructor

@wraithgar wraithgar added the Release 7.x work is associated with a specific npm 7 release label Feb 19, 2021
@eltociear
Copy link
Contributor Author

@wraithgar Thank you for your reply!
I've changed it. please re-review.

@wraithgar wraithgar added the release: next These items should be addressed in the next release label Feb 20, 2021
@eltociear @nlf
test: fix typo in shrinkwrap.js
9d81e0c 
contructor -> constructor

PR-URL: npm#2729
Credit: @eltociear
Close: npm#2729
Reviewed-by: @wraithgar
@nlf nlf changed the base branch from latest to release/v7.5.5 February 22, 2021 17:13
@nlf nlf merged commit 9d81e0c into npm:release/v7.5.5 Feb 22, 2021
@nlf nlf mentioned this pull request Feb 22, 2021
Merged
@ruyadorno ruyadorno mentioned this pull request Feb 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eltociear @wraithgar @nlf