Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unnecessary variables and ESLint errors #3453

Closed
Ivan12273 opened this issue Jun 22, 2021 · 0 comments
Closed

fix: Unnecessary variables and ESLint errors #3453

Ivan12273 opened this issue Jun 22, 2021 · 0 comments
Labels
Enhancement new feature or improvement 💎 Free Internet Points 💎 similar to "Good First issue" - although more impactful Good First Issue good issue or PR for newcomers semver:patch semver patch level for changes

Comments

@Ivan12273
Copy link
Contributor

Ivan12273 commented Jun 22, 2021

Hi, while I was reading the code I found that there are variables that are never used:

image

In the file ls.js the function getChildren do a filter by the selected workspaces an other by edges types if shouldSkipChildren is false.

The function "filterByEdgesTypes" filter debs by type and allows for: npm ls [--dev, --prod, --link, etc.]

image

But the variables node and tree are never used by this function.

Also, the npx-cli.js file have problems related to ESLint style.

In order to prevent future errors and have a more clear code, if there is no problem, I will submit a pull request with the changes I did :)

@darcyclarke darcyclarke added 💎 Free Internet Points 💎 similar to "Good First issue" - although more impactful Enhancement new feature or improvement Good First Issue good issue or PR for newcomers semver:patch semver patch level for changes labels Jun 23, 2021
@darcyclarke darcyclarke changed the title Unnecessary variables and ESLint errors fix: Unnecessary variables and ESLint errors Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement 💎 Free Internet Points 💎 similar to "Good First issue" - although more impactful Good First Issue good issue or PR for newcomers semver:patch semver patch level for changes
Projects
None yet
Development

No branches or pull requests

3 participants