Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install.sh): don't remove old npm first #3748

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

wraithgar
Copy link
Member

The install script will gracefully fail if things don't work. This is
especially important for versions of npm that won't work in your current
node version.

@wraithgar wraithgar requested a review from a team as a code owner September 13, 2021 18:35
Copy link
Contributor

@isaacs isaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was to work around old versions of the npm cli that didn't clean up so gracefully if a global install got borked, especially if overwriting an existing module, but now we even handle unix signals gracefully other than SIGKILL, so I think this is the right way to go.

The install script will gracefully fail if things don't work.  This is
especially important for versions of npm that won't work in your current
node version.

PR-URL: #3748
Credit: @wraithgar
Close: #3748
Reviewed-by: @isaacs
@wraithgar wraithgar merged commit e4a5218 into release-next Sep 13, 2021
@wraithgar wraithgar deleted the gar/install-no-rm branch September 13, 2021 20:41
@fritzy fritzy mentioned this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants