-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] npm undeprecate still not working #3838
Comments
I'm not sure I have exactly the same problem, but I temporarily edited async deprecate([pkg, msg]) {
if (!pkg) // <---- this used to read `if (!pkg || !msg)` But this means if you forget the message it will always undeprecate, which doesn't seem right. The correct fix is probably to have a separate flag or a special message that causes undeprecation, since |
I totally agree, |
This appears to have been fixed since this issue was created. There was a PR that fixed the regression here: #3484. I was able to deprecate and un-deprecate two test packages, one with only one version and one with multiple versions.
|
Is there an existing issue for this?
Current Behavior
npm ERR! code E400
npm ERR! 400 Bad Request - PUT https://registry.npmjs.org/@globules-io%2fogx.js - deprecations must be strings
28 verbose stack HttpErrorGeneral: 400 Bad Request - PUT https://registry.npmjs.org/@globules-io%2fogx.js - deprecations must be strings
Expected Behavior
undeprecate a package
Steps To Reproduce
npm deprecate @globules-io/ogx.js@1.8.6 ""
Environment
The text was updated successfully, but these errors were encountered: