Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @npmcli/template-oss@3.2.2 #4639

Merged
merged 3 commits into from
Mar 30, 2022
Merged

deps: @npmcli/template-oss@3.2.2 #4639

merged 3 commits into from
Mar 30, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Mar 29, 2022

  • add some basic tests for docs
  • make dockhand script work on windows
  • cleanup main CI to match template-oss
  • add a git status check for cli ci tests
  • use resetdeps for ci steps

@lukekarrys lukekarrys requested a review from a team as a code owner March 29, 2022 23:43
@lukekarrys lukekarrys force-pushed the lk/ci-cleanup branch 3 times, most recently from e6df61b to 58e8a61 Compare March 30, 2022 00:01
@npm-robot
Copy link
Contributor

npm-robot commented Mar 30, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 54.267 ±5.71 31.796 ±0.38 29.192 ±15.00 21.544 ±0.50 3.223 ±0.01 3.209 ±0.08 2.625 ±0.11 12.377 ±0.17 2.589 ±0.02 3.672 ±0.03
#4639 54.776 ±5.51 32.335 ±0.12 28.393 ±12.94 22.066 ±0.21 3.289 ±0.02 3.249 ±0.02 2.622 ±0.10 12.621 ±0.06 2.644 ±0.00 3.889 ±0.13
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 38.656 ±4.16 25.012 ±0.07 14.116 ±0.07 14.952 ±0.09 2.972 ±0.03 2.932 ±0.01 2.600 ±0.05 9.220 ±0.07 2.414 ±0.03 3.330 ±0.04
#4639 40.905 ±0.57 25.540 ±0.11 14.220 ±0.20 15.418 ±0.34 2.976 ±0.04 2.950 ±0.05 2.631 ±0.01 9.280 ±0.13 2.479 ±0.03 3.394 ±0.09

@lukekarrys lukekarrys force-pushed the lk/ci-cleanup branch 14 times, most recently from 752a2c0 to a419ca7 Compare March 30, 2022 07:14
@lukekarrys lukekarrys changed the title chore: @npmcli/template-oss@3.2.2 deps: @npmcli/template-oss@3.2.2 Mar 30, 2022
- add some basic tests for docs
- make dockhand script work on windows
- cleanup main CI to match template-oss
- add a git status check for cli ci tests
- use resetdeps for ci steps
Makefile Show resolved Hide resolved
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing ci-docs to not use a matrix can be a future template-oss fix.

@lukekarrys
Copy link
Contributor Author

Fixing ci-docs to not use a matrix can be a future template-oss fix.

template-oss does support this, which i just pushed a fixup to do. i left the platform matrix in there because i fixed a windows bug with the doc creation script.

- run: node ./bin/npm-cli.js run smoke-tests --ignore-scripts
- name: git status
if: matrix.platform.os != 'windows-latest'
run: node scripts/git-dirty.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to highlight that I could not get the git-dirty check to work on windows. I'm ok with that for now, but this might lead to problems for external contributors on windows.

@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants