Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate username at get-identity #5884

Merged
merged 4 commits into from
Nov 30, 2022
Merged

fix: Validate username at get-identity #5884

merged 4 commits into from
Nov 30, 2022

Conversation

sosoba
Copy link
Contributor

@sosoba sosoba commented Nov 22, 2022

Currently npm accept null / undefined / empty string as valid username.
Client should validate incomming data.

References

Fixes #5867 (prevent undefined username)

@sosoba
Update get-identity.js
60ee40c 
Fix for #5867 (prevent undefined username)
@sosoba sosoba requested a review from a team as a code owner November 22, 2022 06:09
@sosoba sosoba changed the title Update get-identity.js fix: Validate username at get-identity Nov 22, 2022
nlf
nlf reviewed Nov 23, 2022
View reviewed changes
lib/utils/get-identity.js Outdated Show resolved Hide resolved
@sosoba @nlf
Update lib/utils/get-identity.js
373676b 
Co-authored-by: nlf <nlf@github.com>
@fritzy fritzy merged commit c26d708 into npm:latest Nov 30, 2022
@github-actions github-actions bot mentioned this pull request Nov 30, 2022
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm whoami allow empty username
3 participants
@sosoba @nlf @fritzy