-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: discrete npm doctor commands #5888
Conversation
currently just checks if global bin is in $PATH
no statistically significant performance changes detected timing results
|
I can edit this to include docs once we've bikeshed the subcommand names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. We can bikeshed the subcommand name next standup.
Usage is driven by actual code, commands are tagged for grouping
a6066ec
to
bf7fb3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless there are objections, i think this makes sense to me. the groupings are named well enough to be intuitive.
Please squash this one when merging. |
Changed output to display as each check finishes instead of all at once at the end.
Check added:
checkBinPath
. Checks that the global bin is in your path.Added grouping to commands.