Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deprecate): ignore implicit workspace mode #6758

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

wraithgar
Copy link
Member

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner September 1, 2023 19:39
@npm-cli-bot
Copy link
Collaborator

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 45.062 ±1.05 25.419 ±0.21 24.479 ±0.14 27.622 ±0.39 3.859 ±0.01 3.784 ±0.08 3.216 ±0.02 17.012 ±0.05 3.195 ±0.03 4.679 ±0.03 0.545 ±0.00 0.634 ±0.01
#6758 0.132 ±0.01 0.129 ±0.00 0.135 ±0.00 0.137 ±0.01 0.141 ±0.00 0.133 ±0.01 0.133 ±0.00 0.133 ±0.01 0.134 ±0.00 0.141 ±0.01 0.535 ±0.02 0.611 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 32.250 ±0.71 19.521 ±0.21 18.737 ±0.34 20.018 ±0.31 3.458 ±0.03 3.477 ±0.03 3.306 ±0.15 12.637 ±0.29 3.090 ±0.05 4.330 ±0.01 0.541 ±0.00 0.588 ±0.00
#6758 0.137 ±0.00 0.134 ±0.00 0.135 ±0.01 0.135 ±0.00 0.137 ±0.00 0.132 ±0.00 0.138 ±0.00 0.138 ±0.01 0.132 ±0.00 0.133 ±0.00 0.532 ±0.02 0.616 ±0.02

@lukekarrys
Copy link
Contributor

Is this in reference to an open issue? I'm missing some context about what this changes when running npm deprecate I think.

@wraithgar
Copy link
Member Author

This was in response to a support ticket. If someone is inside a workspace this command doesn't work. This command requires you to specify a package name, it never infers it from cwd. So, whether or not you're inside a workspace is irrelevant.

@lukekarrys
Copy link
Contributor

:shipit: thanks for reminding me what ignoreImplicitWorkspace does 😄

@wraithgar wraithgar merged commit fb1b674 into latest Sep 11, 2023
20 checks passed
@wraithgar wraithgar deleted the gar/deprecate-ws branch September 11, 2023 17:37
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants