Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
exit-handler.js
to be a class so that it can more easily track its internal state. It uses this state to now fully distinguish between 3 states: npm never being set, npm not loaded, and exit handler never called. There are some new error messages shown via console.error if we know we are in an unexpected state.This also continues the refactoring started in #7415 to separate concerns between
npm
andCLI
. Identifying the error message and logging it have been move tonpm
but catching that error and setting theprocess.exitCode
are still handled inexit-handler.js
andcli/entry.js
.It also moves
command.cmdExec
tonpm
since it never called from within anycommand
instance. This letsnpm
only ever callcommand.exec
orcommand.workspaceExec
now.