Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm audit fix breaks stuff real bad #8029

Open
2 tasks done
kim-broot opened this issue Jan 14, 2025 · 0 comments
Open
2 tasks done

[BUG] npm audit fix breaks stuff real bad #8029

kim-broot opened this issue Jan 14, 2025 · 0 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps

Comments

@kim-broot
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

npm told me I had vulnerabilities that could be fixed using npm audit fix. So I decided to give it a shot. Everything was committed to git, so my code was save (in my mind). But somehow npm audit fix does changes to more than just package.json and package-lock.json. It seems to have completely broken my project to the point where all I can get out of it is an error during webpack that says "[object Object]".
This is definitely not an acceptable way for any software to work and I think it should be fixed urgently, as other people might fall into the same trap.

Expected Behavior

I expected dependencies to be updated, which I could easily revert by deleting node_modules and package-lock.json. However some magical other changes also occur, seemingly breaking the project.

Steps To Reproduce

  • create an SPFx webpart project using react.
  • run npm audit fix
  • nothing works anymore

Environment

No response

@kim-broot kim-broot added Bug thing that needs fixing Needs Triage needs review for next steps labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps
Projects
None yet
Development

No branches or pull requests

1 participant