Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse gitlab url have BUG #23

Closed
maxming2333 opened this issue Mar 17, 2017 · 1 comment
Closed

parse gitlab url have BUG #23

maxming2333 opened this issue Mar 17, 2017 · 1 comment

Comments

@maxming2333
Copy link

Test git url : git@gitlab.demo-ice.com:page/fe-demo.git

Eg:

var hostedGitInfo = require("hosted-git-info")
var info = hostedGitInfo.fromUrl("git@gitlab.demo-ice.com:page/fe-demo.git");
console.log(info); // ==> undefined
@iarna
Copy link
Contributor

iarna commented Mar 17, 2017

This is correct. This only parses gitlab URLs hosted by gitlab.com. That's the "hosted" in "hosted-git-info". There's no way for us to distinguish a self-hosted gitlab (or github enterprise instance) from any other git server as there's no difference in the url format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants