Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This package cannot handle Gitlab subgroups #54

Open
smzelek opened this issue Oct 16, 2019 · 2 comments
Open

This package cannot handle Gitlab subgroups #54

smzelek opened this issue Oct 16, 2019 · 2 comments

Comments

@smzelek
Copy link

smzelek commented Oct 16, 2019

    "repository": {
        "type": "git",
        "url": "git@git.DOMAIN.com:GROUP/SUBGROUP/REPO.git"
    },

The tool breaks and uses the unknownHostInfo if you have a subgroup.

@gabemeola
Copy link

Also similar: #39

@dbrakman
Copy link

dbrakman commented Jan 4, 2023

I think this issue should be re-titled, closed, and consolidated into #39. The OP requires an intersection of features for parsing "git@git.DOMAIN.com:GROUP/SUBGROUP/REPO.git": both enterprise, self-hosted gitlab urls and gitlab subgroups would need to be supported. The title only mentions the latter, which has been listed as resolved in #56 and #43.

I confirm that on my machine, Mac OS Ventura 13.1 with npm 9.2.0 and node version 19.3.0, Gitlab subgroups are supported in hosted-git-info version 6.1.1:

hostedGitInfo = requires("hosted-git-info")
hostedGitInfo.fromUrl("git@gitlab.com:company/department/project.git")

returns a GitHost object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants