Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated String.prototype.substr() #27

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Apr 5, 2022

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@wraithgar wraithgar requested a review from a team as a code owner April 5, 2022 19:17
@wraithgar
Copy link
Member Author

rebase of #19

@wraithgar wraithgar merged commit a173abe into main Apr 5, 2022
@wraithgar wraithgar deleted the rm-deprecated-substr branch April 5, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants