Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

image src is parsed error #415

Open
hiowenluke opened this issue Oct 2, 2017 · 3 comments
Open

image src is parsed error #415

hiowenluke opened this issue Oct 2, 2017 · 3 comments

Comments

@hiowenluke
Copy link

hiowenluke commented Oct 2, 2017

The following code:

<a href='https://github.com/tasjs/fac' target='_blank'>
<img width='150' src='./res/logo_icon_150.png' /><br />
<img height='60' src='./res/slogan.png' />
</a>

the 1st src is correctly parsed, see: https://github.com/tasjs/fac .
but the 2nd src is not (the image is not shown), see: https://www.npmjs.com/package/fac .

@revin
Copy link
Collaborator

revin commented Oct 5, 2017

Interesting, @hiowenluke, thanks for the report! I see it in the generated markup on the npm site, but the path to the PNG file hasn't been rewritten to the GitHub URL for some reason. I guess that's where we'll have to start investigating...

@revin
Copy link
Collaborator

revin commented Oct 6, 2017

How typical. This was a mistake on my end. 🙄 Submitted a PR.

@hiowenluke
Copy link
Author

That's great! Thank you @revin .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants