Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Back-port to v6 the fix for Regular Expression Denial of Service #577

Closed
1 task done
Tracked by #581
joshuanapoli opened this issue Jun 26, 2023 · 2 comments
Closed
1 task done
Tracked by #581
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@joshuanapoli
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

  • Current versions of babel depend on semver@^6.3.0. This version has "Vulnerable to Regular Expression Denial of Service " CVE-2022-25883.
  • The babel team does not want to upgrade to the fixed version semver@^7.5.2, because it would be a breaking change (see [Bug]: [Security][helper-compilation-targets] Dependency semver version has vulnerability babel/babel#15720).
  • The babel team asserts that the "vulnerability" isn't relevant to babel. Unfortunately, this still leaves a burden on all dependent projects to analyze the situation. Is "ReDOS" relevant to me? Am I using vulnerable "semver" outside of babel? These aren't necessarily easy to answer.

Expected Behavior

Would you mind back-porting ReDOS fix to version 6? :-)

Steps To Reproduce

In a project that depends on babel v7:

  • npm audit shows a CVE-2022-25883 vulnerability because of semver
  • GitHub Security Alerts also show the vulnerability because of semver

Environment

N/A

@joshuanapoli joshuanapoli added Bug thing that needs fixing Needs Triage needs an initial review labels Jun 26, 2023
@wraithgar
Copy link
Member

Please see the discussion in #564

Duplicate of #576

@stocaaro
Copy link

Where is the open issue tracking the release of the backport work proposed by @joaomoreno on #564?

I understand that there is no process for this (as described on this issue #576 (comment)), but this seems like the right solution to fix this issue for the >46% of semver users who still depend on v5 and v6 via deep dependency trees.

@Gornator Gornator mentioned this issue Jul 2, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Development

No branches or pull requests

3 participants