Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to not replace magic registry host #143

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Mar 16, 2022

By default, a package manifest might contain dist tarballs with "registry.npmjs.org" hosts, which will be replaced automatically with the configured registry host.

This PR adds an option, replaceRegistryHost, which is true by default.

When set to false, "registry.npmjs.org" is no longer treated like a magic value.

@fritzy fritzy requested a review from a team as a code owner March 16, 2022 22:57
lib/fetcher.js Outdated Show resolved Hide resolved
lib/fetcher.js Outdated Show resolved Hide resolved
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion for a comment, approved either way.

test/registry.js Outdated Show resolved Hide resolved
@fritzy fritzy force-pushed the fritzy/replace-registry branch 3 times, most recently from f78c223 to 0e9cb53 Compare April 5, 2022 21:10
@fritzy fritzy merged commit f519cf4 into main Apr 5, 2022
@fritzy fritzy deleted the fritzy/replace-registry branch April 5, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants