Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-pr): should account for missing releases in PR body #373

Closed
3 tasks
darcyclarke opened this issue Jun 18, 2021 · 1 comment
Closed
3 tasks

feat(node-pr): should account for missing releases in PR body #373

darcyclarke opened this issue Jun 18, 2021 · 1 comment
Labels
chore

Comments

@darcyclarke
Copy link
Contributor

Summary

Currently the Node PR workflow/automation only pulls the specific release changelog to be used in the PR's body.

Exit Criteria

  • the workflow should keep our fork (ie. npm/node#master) up-to-date with nodejs/node#master
  • the workflow should find all npm releases that have gone out since the version that we find in #master
  • the workflow should add all the release's changelogs to the PR body, not just the last/latest one (ex. deps: upgrade npm to 7.18.1 nodejs/node#39065 (comment))
@darcyclarke darcyclarke added this to the OSS - Sprint 32 milestone Jun 18, 2021
@darcyclarke darcyclarke changed the title fix(node-pr-workflow): should account for missing releases in PR body fix(node-pr): should account for missing releases in PR body Jun 18, 2021
@darcyclarke darcyclarke changed the title fix(node-pr): should account for missing releases in PR body feat(node-pr): should account for missing releases in PR body Jun 18, 2021
@gijun19 gijun19 self-assigned this Jun 24, 2021
@darcyclarke darcyclarke modified the milestones: OSS - Sprint 34, OSS - Sprint 35 Aug 9, 2021
@settings settings bot removed the Task label Aug 31, 2021
@wraithgar
Copy link
Member

the current release process handles all of these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wraithgar @darcyclarke @gijun19