Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Install Strategy Bugs and Feedback #637

Open
2 of 5 tasks
Tracked by #639
fritzy opened this issue Jan 26, 2023 · 7 comments
Open
2 of 5 tasks
Tracked by #639

Linked Install Strategy Bugs and Feedback #637

fritzy opened this issue Jan 26, 2023 · 7 comments
Assignees

Comments

@fritzy
Copy link

fritzy commented Jan 26, 2023

This issue tracks known issues, feedback, fixes, and broken repos for --install-strategy=linked

Known Issues/Fixes:

  • workspace specific installs failing
    • .children should be CaseInsensitiveMap
    • .inventory might as well be Inventory
  • .bin discovery failing (although placed correctly)
  • package cleanup breaking on failed installs (possibly related to build scripts)

Known Failed Repos/Packages:

@fritzy fritzy self-assigned this Jan 26, 2023
@fritzy
Copy link
Author

fritzy commented Jan 31, 2023

  • write team post

@saquibkhan
Copy link

are the bugs fixed, can we close this issue?

@nlf
Copy link

nlf commented Feb 8, 2023

here's another known bug - npm/cli#6125

@saquibkhan
Copy link

I am labelling all issues with install-linked-strategy - https://github.com/npm/cli/issues?q=is%3Aissue+is%3Aopen+linked+label%3Ainstall-linked-strategy

@saquibkhan
Copy link

@fritzy any updates on bug fixes?

@fritzy
Copy link
Author

fritzy commented Feb 16, 2023

@MylesBorins npm/documentation still doesn't work, because the dependency graphql-compose was working by coincidence. It requires the package graphql, and only resolved when other packages installed it hoisted.

But it at least installs all of the modules properly now.

@saquibkhan
Copy link

@MylesBorins npm/documentation still doesn't work, because the dependency graphql-compose was working by coincidence. It requires the package graphql, and only resolved when other packages installed it hoisted.

But it at least installs all of the modules properly now.

as discussed we should call out in our doc, pin the issue so community is aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants